Skip to content

Commit 56ca0db

Browse files
committed
fix: removes template path suppression from Renovate
The built-in github-actions manager should detect template files — they contain real SHA-pinned deps that need updating. Dashboard duplication with the regex manager is cosmetic; Renovate deduplicates actual update PRs.
1 parent ad4f0ac commit 56ca0db

3 files changed

Lines changed: 0 additions & 22 deletions

File tree

.github/renovate.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@
3232
"matchUpdateTypes": ["major"],
3333
"groupName": "major dependencies",
3434
"groupSlug": "major"
35-
},
36-
{
37-
"matchManagers": ["github-actions"],
38-
"matchFileNames": ["template/**"],
39-
"enabled": false
4035
}
4136
]
4237
}

template/.github/renovate.json.jinja

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,6 @@
1919
"matchUpdateTypes": ["major"],
2020
"groupName": "major dependencies",
2121
"groupSlug": "major"
22-
}{{ ',' if _is_template else '' }}
23-
{% if _is_template %}
24-
{
25-
"matchManagers": ["github-actions"],
26-
"matchFileNames": ["template/**"],
27-
"enabled": false
2822
}
29-
{% endif %}
3023
]
3124
}

tests/test_rendering.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -287,16 +287,6 @@ def test_renovate_has_template_config(generated_template_project):
287287
assert template_managers, "No template-specific customManagers found"
288288

289289

290-
def test_renovate_template_suppresses_builtin_gha(generated_template_project):
291-
"""Template repo disables built-in github-actions manager for template paths."""
292-
data = parse_json(generated_template_project / ".github" / "renovate.json")
293-
rules = data.get("packageRules", [])
294-
gha_rule = [r for r in rules if r.get("matchManagers") == ["github-actions"]]
295-
assert gha_rule, "No packageRule suppressing github-actions for template paths"
296-
assert gha_rule[0].get("matchFileNames") == ["template/**"]
297-
assert gha_rule[0].get("enabled") is False
298-
299-
300290
def test_no_consistency_job_default(generated_github_project):
301291
"""Default projects have no consistency job in pr-checks."""
302292
assert "consistency" not in (generated_github_project / ".github" / "workflows" / "pr-checks.yaml").read_text()

0 commit comments

Comments
 (0)