test: fixes userEvent consistency and adds multi-page test

Author: wgordon17

tests/components/ExpandCollapseButtons.test.tsx

@@ -1,5 +1,6 @@
 import { describe, it, expect, vi } from "vitest";
-import { render, screen, fireEvent } from "@solidjs/testing-library";
+import { render, screen } from "@solidjs/testing-library";
+import userEvent from "@testing-library/user-event";
 import ExpandCollapseButtons from "../../src/app/components/shared/ExpandCollapseButtons";
 
 describe("ExpandCollapseButtons", () => {
@@ -9,17 +10,19 @@ describe("ExpandCollapseButtons", () => {
     expect(screen.getByRole("button", { name: "Collapse all" })).toBeTruthy();
   });
 
-  it("calls onExpandAll when expand button is clicked", () => {
+  it("calls onExpandAll when expand button is clicked", async () => {
+    const user = userEvent.setup();
     const onExpandAll = vi.fn();
     render(() => <ExpandCollapseButtons onExpandAll={onExpandAll} onCollapseAll={() => {}} />);
-    fireEvent.click(screen.getByRole("button", { name: "Expand all" }));
+    await user.click(screen.getByRole("button", { name: "Expand all" }));
     expect(onExpandAll).toHaveBeenCalledTimes(1);
   });
 
-  it("calls onCollapseAll when collapse button is clicked", () => {
+  it("calls onCollapseAll when collapse button is clicked", async () => {
+    const user = userEvent.setup();
     const onCollapseAll = vi.fn();
     render(() => <ExpandCollapseButtons onExpandAll={() => {}} onCollapseAll={onCollapseAll} />);
-    fireEvent.click(screen.getByRole("button", { name: "Collapse all" }));
+    await user.click(screen.getByRole("button", { name: "Collapse all" }));
     expect(onCollapseAll).toHaveBeenCalledTimes(1);
   });
 });

tests/components/IssuesTab.test.tsx

@@ -489,4 +489,30 @@ describe("IssuesTab", () => {
     // State persisted in viewState store — should still be expanded
     screen.getByText("Survives remount");
   });
+
+  it("clicking 'Expand all' expands repos on other pages too", async () => {
+    const user = userEvent.setup();
+    updateConfig({ itemsPerPage: 10 });
+    const issues = [
+      ...Array.from({ length: 6 }, (_, i) =>
+        makeIssue({ id: 100 + i, title: `Repo A issue ${i}`, repoFullName: "org/repo-a" })
+      ),
+      ...Array.from({ length: 6 }, (_, i) =>
+        makeIssue({ id: 200 + i, title: `Repo B issue ${i}`, repoFullName: "org/repo-b" })
+      ),
+    ];
+    render(() => <IssuesTab issues={issues} userLogin="" />);
+    // Page 1 shows repo-a, page 2 shows repo-b
+    screen.getByText(/Page 1 of 2/);
+
+    // Expand all — affects repos on ALL pages
+    await user.click(screen.getByLabelText("Expand all"));
+    // Repo-a items visible on page 1
+    screen.getByText("Repo A issue 0");
+
+    // Navigate to page 2 — repo-b should already be expanded
+    await user.click(screen.getByLabelText("Next page"));
+    screen.getByText("org/repo-b");
+    screen.getByText("Repo B issue 0");
+  });
 });

tests/components/PullRequestsTab.test.tsx

@@ -569,4 +569,30 @@ describe("PullRequestsTab", () => {
     render(() => <PullRequestsTab pullRequests={prs} userLogin="" />);
     screen.getByText("Persistent PR");
   });
+
+  it("clicking 'Expand all' expands repos on other pages too", async () => {
+    const user = userEvent.setup();
+    updateConfig({ itemsPerPage: 10 });
+    const prs = [
+      ...Array.from({ length: 6 }, (_, i) =>
+        makePullRequest({ id: 100 + i, title: `Repo A PR ${i}`, repoFullName: "org/repo-a" })
+      ),
+      ...Array.from({ length: 6 }, (_, i) =>
+        makePullRequest({ id: 200 + i, title: `Repo B PR ${i}`, repoFullName: "org/repo-b" })
+      ),
+    ];
+    render(() => <PullRequestsTab pullRequests={prs} userLogin="" />);
+    // Page 1 shows repo-a, page 2 shows repo-b
+    screen.getByText(/Page 1 of 2/);
+
+    // Expand all — affects repos on ALL pages
+    await user.click(screen.getByLabelText("Expand all"));
+    // Repo-a items visible on page 1
+    screen.getByText("Repo A PR 0");
+
+    // Navigate to page 2 — repo-b should already be expanded
+    await user.click(screen.getByLabelText("Next page"));
+    screen.getByText("org/repo-b");
+    screen.getByText("Repo B PR 0");
+  });
 });