Skip to content

Commit 697cbc7

Browse files
committed
Merge branch 'main' of https://github.com/googleapis/google-cloud-python into librarian-20260506T163115Z
2 parents 4412d7a + f655e49 commit 697cbc7

14 files changed

Lines changed: 524 additions & 264 deletions

File tree

.github/workflows/regenerate-all.yml

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ jobs:
4848
go run "github.com/googleapis/librarian/cmd/librarian@${version}" generate -all -v
4949
5050
- name: Create issue on diff
51-
if: failure()
5251
env:
5352
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5453
run: |
@@ -70,4 +69,19 @@ jobs:
7069
echo "Issue #$EXISTING_ISSUE already exists, adding a comment."
7170
gh issue comment "$EXISTING_ISSUE" --body "Another failure with diff occurred: $RUN_URL"
7271
fi
73-
fi
72+
fi
73+
- name: Create issue on generation failure
74+
if: failure()
75+
env:
76+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
77+
run: |
78+
TITLE="Regeneration failed"
79+
RUN_URL="${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
80+
BODY="The post-submit [regeneration check]($RUN_URL) failed."
81+
EXISTING_ISSUE=$(gh issue list --state open --search "in:title \"$TITLE\"" --json number --jq '.[0].number')
82+
if [ -z "$EXISTING_ISSUE" ]; then
83+
gh issue create --title "$TITLE" --body "$BODY"
84+
else
85+
echo "Issue #$EXISTING_ISSUE already exists, adding a comment."
86+
gh issue comment "$EXISTING_ISSUE" --body "Another regeneration failure occurred: $RUN_URL"
87+
fi

.librarian/config.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,8 @@ libraries:
3737
# Disable automatic releases until tests stabilize.
3838
- id: "pandas-gbq"
3939
release_blocked: true
40+
# TODO(https://github.com/googleapis/google-cloud-python/issues/16970):
41+
# Disable automatic releases until system tests are sped up or reorganized.
42+
- id: "google-cloud-firestore"
43+
release_blocked: true
4044

librarian.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1123,6 +1123,7 @@ libraries:
11231123
- docs/firestore_v1/transaction.rst
11241124
- docs/firestore_v1/transforms.rst
11251125
- docs/firestore_v1/types.rst
1126+
skip_release: true
11261127
python:
11271128
library_type: GAPIC_COMBO
11281129
opt_args_by_api:

packages/bigframes/CONTRIBUTING.rst

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -232,11 +232,11 @@ configure them just like the System Tests.
232232

233233
# Run all tests in a folder
234234
$ cd samples/snippets
235-
$ nox -s py-3.8
235+
$ nox -s py-3.10
236236

237237
# Run a single sample test
238238
$ cd samples/snippets
239-
$ nox -s py-3.8 -- -k <name of test>
239+
$ nox -s py-3.10 -- -k <name of test>
240240

241241
********************************************
242242
Note About ``README`` as it pertains to PyPI
@@ -276,17 +276,7 @@ Supported versions can be found in our ``noxfile.py`` `config`_.
276276
.. _config: https://github.com/googleapis/google-cloud-python/blob/main/packages/bigframes/noxfile.py
277277

278278

279-
We also explicitly decided to support Python 3 beginning with version 3.10.
280-
Reasons for this include:
281279

282-
- Encouraging use of newest versions of Python 3
283-
- Taking the lead of `prominent`_ open-source `projects`_
284-
- `Unicode literal support`_ which allows for a cleaner codebase that
285-
works in both Python 2 and Python 3
286-
287-
.. _prominent: https://docs.djangoproject.com/en/1.9/faq/install/#what-python-version-can-i-use-with-django
288-
.. _projects: http://flask.pocoo.org/docs/0.10/python3/
289-
.. _Unicode literal support: https://www.python.org/dev/peps/pep-0414/
290280

291281
**********
292282
Versioning

packages/bigframes/bigframes/session/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
from bigframes import version
8181
from bigframes.core import blocks, utils
8282
from bigframes.core.logging import log_adapter
83-
from bigframes.session import bigquery_session, bq_caching_executor, executor
83+
from bigframes.session import bigquery_session, executor, proxy_executor
8484

8585
# Avoid circular imports.
8686
if typing.TYPE_CHECKING:
@@ -327,15 +327,15 @@ def __init__(
327327
if not self._strictly_ordered:
328328
labels["bigframes-mode"] = "unordered"
329329

330-
self._executor: executor.Executor = bq_caching_executor.BigQueryCachingExecutor(
330+
self._executor: executor.Executor = proxy_executor.DualCompilerProxyExecutor(
331331
bqclient=self._clients_provider.bqclient,
332332
bqstoragereadclient=self._clients_provider.bqstoragereadclient,
333333
loader=self._loader,
334334
storage_manager=self._temp_storage_manager,
335335
metrics=self._metrics,
336336
enable_polars_execution=context.enable_polars_execution,
337337
publisher=self._publisher,
338-
labels=labels,
338+
labels=tuple(labels.items()),
339339
)
340340

341341
def __del__(self):

0 commit comments

Comments
 (0)