Skip to content

Commit 4356c59

Browse files
committed
refactor: restore Executor.execute to synchronous def to match public interface
1 parent 4b536fd commit 4356c59

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/bigframes/bigframes/session/executor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ def to_sql(
321321
raise NotImplementedError("to_sql not implemented for this executor")
322322

323323
@abc.abstractmethod
324-
async def execute(
324+
def execute(
325325
self,
326326
array_value: bigframes.core.ArrayValue,
327327
execution_spec: ex_spec.ExecutionSpec,

packages/bigframes/bigframes/testing/polars_session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
class TestExecutor(bigframes.session.executor.Executor):
3434
compiler = bigframes.core.compile.polars.PolarsCompiler()
3535

36-
async def execute(
36+
def execute(
3737
self,
3838
array_value: bigframes.core.ArrayValue,
3939
execution_spec: bigframes.session.execution_spec.ExecutionSpec,

packages/bigframes/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1048,7 +1048,7 @@ def mypy(session):
10481048
# Editable mode is not compatible with mypy when there are multiple
10491049
# package directories. See:
10501050
# https://github.com/python/mypy/issues/10564#issuecomment-851687749
1051-
session.install(".")
1051+
session.install("--no-cache-dir", ".")
10521052

10531053
# Just install the dependencies' type info directly, since "mypy --install-types"
10541054
# might require an additional pass.

0 commit comments

Comments
 (0)