Skip to content

test(spanner): Fix Spanner presubmit trampoline and system tests#8327

Merged
surbhigarg92 merged 1 commit into
mainfrom
fix-trampoline-diff-check
May 21, 2026
Merged

test(spanner): Fix Spanner presubmit trampoline and system tests#8327
surbhigarg92 merged 1 commit into
mainfrom
fix-trampoline-diff-check

Conversation

@sakthivelmanii
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label Bot added the api: spanner Issues related to the Spanner API. label May 20, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the PROJECT_ROOT calculation in trampoline_v2.sh by removing a hardcoded subdirectory suffix and adds a shallow git fetch to ensure the commit history is available for diffing in CI environments. Review feedback suggests double-quoting $(pwd) to prevent word splitting in paths containing spaces and removing the suppression of stderr in the git fetch command to improve observability for debugging CI failures.

Comment thread handwritten/spanner/.kokoro/trampoline_v2.sh Outdated
Comment thread handwritten/spanner/.kokoro/trampoline_v2.sh
@sakthivelmanii sakthivelmanii force-pushed the fix-trampoline-diff-check branch 3 times, most recently from b3ac480 to 7b750f8 Compare May 20, 2026 12:35
@sakthivelmanii sakthivelmanii changed the title test(spanner): Fix systest presubmit jobs test: Fix systest presubmit jobs May 20, 2026
@sakthivelmanii sakthivelmanii force-pushed the fix-trampoline-diff-check branch 8 times, most recently from e6304e3 to d93fc5b Compare May 20, 2026 19:33
@sakthivelmanii sakthivelmanii changed the title test: Fix systest presubmit jobs test(spanner): Fix Spanner presubmit trampoline and system tests May 20, 2026
@sakthivelmanii sakthivelmanii force-pushed the fix-trampoline-diff-check branch from d93fc5b to 8648f70 Compare May 20, 2026 19:35
@sakthivelmanii sakthivelmanii marked this pull request as ready for review May 20, 2026 19:36
@sakthivelmanii sakthivelmanii requested a review from a team as a code owner May 20, 2026 19:36
@surbhigarg92 surbhigarg92 merged commit de80308 into main May 21, 2026
29 checks passed
@surbhigarg92 surbhigarg92 deleted the fix-trampoline-diff-check branch May 21, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants