test(spanner): Fix Spanner presubmit trampoline and system tests#8327
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the PROJECT_ROOT calculation in trampoline_v2.sh by removing a hardcoded subdirectory suffix and adds a shallow git fetch to ensure the commit history is available for diffing in CI environments. Review feedback suggests double-quoting $(pwd) to prevent word splitting in paths containing spaces and removing the suppression of stderr in the git fetch command to improve observability for debugging CI failures.
b3ac480 to
7b750f8
Compare
e6304e3 to
d93fc5b
Compare
d93fc5b to
8648f70
Compare
surbhigarg92
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕