Skip to content

fix(build): correct git diff pathspec in trampoline scripts for CI presubmit checks#8326

Closed
sakthivelmanii wants to merge 10 commits into
mainfrom
fix-trampoline-diff-check
Closed

fix(build): correct git diff pathspec in trampoline scripts for CI presubmit checks#8326
sakthivelmanii wants to merge 10 commits into
mainfrom
fix-trampoline-diff-check

Conversation

@sakthivelmanii
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@sakthivelmanii sakthivelmanii requested a review from a team as a code owner May 20, 2026 10:20
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a trailing newline to the trampoline script. Feedback indicates that while the PR title suggests a fix for a git diff pathspec, the actual logic changes are missing from the commit.

Comment thread handwritten/spanner/.kokoro/trampoline_v2.sh
@sakthivelmanii sakthivelmanii force-pushed the fix-trampoline-diff-check branch from 3f16c1d to b25e7bc Compare May 20, 2026 10:26
@sakthivelmanii sakthivelmanii requested review from a team as code owners May 20, 2026 10:26
@sakthivelmanii sakthivelmanii force-pushed the fix-trampoline-diff-check branch from b25e7bc to a59ad04 Compare May 20, 2026 10:36
@sakthivelmanii sakthivelmanii requested a review from a team as a code owner May 20, 2026 10:36
@sakthivelmanii sakthivelmanii force-pushed the fix-trampoline-diff-check branch 5 times, most recently from 29604ca to d9e997c Compare May 20, 2026 11:02
@sakthivelmanii sakthivelmanii force-pushed the fix-trampoline-diff-check branch from d9e997c to 5b54004 Compare May 20, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant