Allow generation of empty match condition term with counter action.

PiperOrigin-RevId: 745559392

Author: Capirca Team

capirca/lib/arista_tp.py

@@ -233,14 +233,17 @@ def __str__(self):
         self.term.hop_limit or self.term.port or self.term.protocol or
         self.term.protocol_except or self.term.source_address or
         self.term.source_address_exclude or self.term.source_port or
-        self.term.source_prefix or self.term.ttl)
+        self.term.source_prefix or self.term.ttl )
 
     # if the term name is default-* we will render this into the
     # appropriate default term name to be used in this filter.
     is_default_term = re.match(r"^ipv(4|6)\-default\-.*", self.term.name,
                                re.IGNORECASE)
 
-    if (not has_match_criteria and not is_default_term):
+    # if the term doesn't match on anything and isn't a default-term and
+    # isn't a counter term, then we don't render it.
+    if (not has_match_criteria and not is_default_term
+        and not self.term.counter):
       # this term doesn't match on anything and isn't a default-term
       logging.warning(
           "WARNING: term %s has no valid match criteria and "

tests/lib/arista_tp_test.py

@@ -359,6 +359,12 @@
   action:: deny
 }
 """
+NO_MATCH_TERM_COUNTER = """
+term deny-and-count {
+  counter:: deny-counter
+  action:: deny
+}
+"""
 LONG_COMMENT_TERM_1 = """
 term long-comment-term-1 {
   comment:: "this is very very very very very very very very very very very
@@ -801,6 +807,13 @@ def testDefaultDeny(self):
     self.assertIn("match ipv4-default-all ipv4", output, output)
     self.assertIn("match ipv6-default-all ipv6", output, output)
 
+  def testEmptyMatchDenyCounter(self):
+    atp = arista_tp.AristaTrafficPolicy(
+        policy.ParsePolicy(GOOD_HEADER + NO_MATCH_TERM_COUNTER, self.naming),
+        EXP_INFO)
+    output = str(atp)
+    self.assertIn("count deny-counter", output, output)
+
   def testIcmpType(self):
     atp = arista_tp.AristaTrafficPolicy(
         policy.ParsePolicy(GOOD_HEADER + GOOD_TERM_3, self.naming), EXP_INFO)