fix: address catalog env and priority review

Author: Adr1an04

src/specify_cli/__init__.py

@@ -2593,7 +2593,7 @@ def integration_search(
         raise typer.Exit(1)
     except IntegrationCatalogError as exc:
         console.print(f"[red]Error:[/red] {exc}")
-        if os.environ.get("SPECKIT_INTEGRATION_CATALOG_URL"):
+        if os.environ.get("SPECKIT_INTEGRATION_CATALOG_URL", "").strip():
             console.print(
                 "\nTip: Check the SPECKIT_INTEGRATION_CATALOG_URL environment variable for an invalid "
                 "catalog URL, or unset it to use the configured catalog files "
@@ -2731,7 +2731,7 @@ def integration_info(
                 "(.specify/integration-catalogs.yml or ~/.specify/integration-catalogs.yml), "
                 "or use a built-in integration ID directly."
             )
-        elif os.environ.get("SPECKIT_INTEGRATION_CATALOG_URL"):
+        elif os.environ.get("SPECKIT_INTEGRATION_CATALOG_URL", "").strip():
             console.print(
                 "\nCheck whether SPECKIT_INTEGRATION_CATALOG_URL is set correctly and reachable, "
                 "or unset it to use the configured catalog files, or use a built-in integration ID directly."

src/specify_cli/integrations/catalog.py

@@ -650,10 +650,14 @@ def _is_removable_catalog_entry(item: Any) -> bool:
             if not _is_removable_catalog_entry(item):
                 continue
 
-            try:
-                priority = int(item.get("priority", yaml_idx + 1))
-            except (TypeError, ValueError):
+            raw_priority = item.get("priority", yaml_idx + 1)
+            if isinstance(raw_priority, bool):
                 priority = yaml_idx + 1
+            else:
+                try:
+                    priority = int(raw_priority)
+                except (TypeError, ValueError):
+                    priority = yaml_idx + 1
             priority_pairs.append((priority, yaml_idx))
         if not priority_pairs:
             raise IntegrationValidationError(

tests/integrations/test_cli.py

@@ -850,6 +850,31 @@ def test_search_invalid_env_catalog_url_shows_env_tip(
         assert "~/.specify/integration-catalogs.yml" in normalized_output
         assert "temporarily unavailable" not in normalized_output
 
+    def test_search_whitespace_env_catalog_url_uses_generic_catalog_tip(
+        self, tmp_path, monkeypatch
+    ):
+        project = self._make_project(tmp_path)
+        monkeypatch.setenv("SPECKIT_INTEGRATION_CATALOG_URL", "   ")
+
+        from specify_cli.integrations.catalog import (
+            IntegrationCatalog,
+            IntegrationCatalogError,
+        )
+
+        def fail_search(self, **kwargs):
+            raise IntegrationCatalogError("catalog offline")
+
+        monkeypatch.setattr(IntegrationCatalog, "search", fail_search)
+
+        result = self._invoke(["integration", "search"], project)
+        normalized_output = _normalize_cli_output(result.output)
+        assert result.exit_code == 1, result.output
+        assert "temporarily unavailable" in normalized_output
+        assert (
+            "SPECKIT_INTEGRATION_CATALOG_URL environment variable"
+            not in normalized_output
+        )
+
     def test_info_unknown_with_local_config_error_shows_local_config_tip(
         self, tmp_path, monkeypatch
     ):

tests/integrations/test_integration_catalog.py

@@ -1325,6 +1325,35 @@ def test_remove_catalog_display_order_with_missing_priorities(
         data = yaml.safe_load(cfg_path.read_text(encoding="utf-8"))
         assert [c["name"] for c in data["catalogs"]] == ["two", "three"]
 
+    def test_remove_catalog_bool_priority_falls_back_to_yaml_index(
+        self, tmp_path, monkeypatch
+    ):
+        self._isolate(tmp_path, monkeypatch)
+        cfg_path = tmp_path / ".specify" / "integration-catalogs.yml"
+        cfg_path.parent.mkdir(parents=True, exist_ok=True)
+        cfg_path.write_text(
+            yaml.dump(
+                {
+                    "catalogs": [
+                        {"url": "https://one.example.com/c.json", "name": "one"},
+                        {
+                            "url": "https://bool.example.com/c.json",
+                            "name": "bool",
+                            "priority": False,
+                        },
+                    ]
+                }
+            ),
+            encoding="utf-8",
+        )
+        cat = IntegrationCatalog(tmp_path)
+
+        removed = cat.remove_catalog(0)
+
+        assert removed == "one"
+        data = yaml.safe_load(cfg_path.read_text(encoding="utf-8"))
+        assert [c["name"] for c in data["catalogs"]] == ["bool"]
+
     def test_remove_catalog_display_order_skips_blank_url_entries(
         self, tmp_path, monkeypatch
     ):