Skip to content

Commit e17cf37

Browse files
committed
Update FetchRepoCollaborators doc comment for marker-only ingress
Addresses Copilot review on #2478. The helper is no longer called by the server itself; ingress emits a 'private' marker and the client engine resolves readers on demand. Kept exported per the library-consumer convention; updated the comment to reflect the new role.
1 parent d0b2222 commit e17cf37

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

pkg/github/repositories.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -655,10 +655,14 @@ func CreateRepository(t translations.TranslationHelperFunc) inventory.ServerTool
655655
}
656656

657657
// FetchRepoCollaborators returns the login names of all collaborators on a
658-
// repository. It is provided as a shared helper for IFC label computation so
659-
// tools can populate the reader set for private repositories. The full list
660-
// is fetched eagerly via pagination; callers are expected to invoke this only
661-
// when needed (e.g. private repos under InsidersMode).
658+
// repository, paginated.
659+
//
660+
// The github-mcp-server itself no longer calls this from its IFC label paths:
661+
// ingress tools emit a single "private" marker and the client engine resolves
662+
// concrete readers from the GitHub API on demand at egress decision time
663+
// (where it can paginate + cache). The helper is retained as an exported
664+
// utility for external library consumers that may want the same one-shot
665+
// pagination behaviour.
662666
func FetchRepoCollaborators(ctx context.Context, client *github.Client, owner, repo string) ([]string, error) {
663667
opts := &github.ListCollaboratorsOptions{
664668
ListOptions: github.ListOptions{PerPage: 100},

0 commit comments

Comments
 (0)