fix(tests): use MinimalFieldValue for GraphQL field value assertions

iulia-b · web-flow · commit 4a70290af063 · 2026-05-21T13:16:20.000Z
diff --git a/.github/workflows/code-scanning.yml b/.github/workflows/code-scanning.yml
@@ -78,17 +78,17 @@ jobs:
           go-version: ${{ fromJSON(steps.resolve-environment.outputs.environment).configuration.go.version }}
           cache: false
 
-      - name: Set up Node.js (for JavaScript CodeQL)
-        if: matrix.language == 'javascript'
-        uses: actions/setup-node@v6
+      - name: Set up Node.js
+        if: matrix.language == 'go' || matrix.language == 'javascript'
+        uses: actions/setup-node@v4
         with:
           node-version: "20"
           cache: "npm"
           cache-dependency-path: ui/package-lock.json
 
       - name: Build UI
         if: matrix.language == 'go'
-        uses: ./.github/actions/build-ui
+        run: script/build-ui
 
       - name: Autobuild
         uses: github/codeql-action/autobuild@v4
diff --git a/.github/workflows/docker-publish.yml b/.github/workflows/docker-publish.yml
@@ -46,7 +46,7 @@ jobs:
       # https://github.com/sigstore/cosign-installer
       - name: Install cosign
         if: github.event_name != 'pull_request'
-        uses: sigstore/cosign-installer@6f9f17788090df1f26f669e9d70d6ae9567deba6 #v4.1.2
+        uses: sigstore/cosign-installer@ba7bc0a3fef59531c69a25acd34668d6d3fe6f22 #v4.1.0
         with:
           cosign-release: "v2.2.4"
 
@@ -60,7 +60,7 @@ jobs:
       # https://github.com/docker/login-action
       - name: Log into registry ${{ env.REGISTRY }}
         if: github.event_name != 'pull_request'
-        uses: docker/login-action@4907a6ddec9925e35a0a9e82d7399ccc52663121 # v4.1.0
+        uses: docker/login-action@b45d80f862d83dbcd57f89517bcf500b2ab88fb2 # v4.0.0
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}
@@ -93,7 +93,7 @@ jobs:
           key: ${{ runner.os }}-go-build-cache-${{ hashFiles('**/go.sum') }}
 
       - name: Inject go-build-cache
-        uses: reproducible-containers/buildkit-cache-dance@5422eac04292c961a382e0f584ea0f03ad9da723 # v3.4.0
+        uses: reproducible-containers/buildkit-cache-dance@1b8ab18fbda5ad3646e3fcc9ed9dd41ce2f297b4 # v3.3.2
         with:
           cache-map: |
             {
diff --git a/.github/workflows/docs-check.yml b/.github/workflows/docs-check.yml
@@ -16,8 +16,15 @@ jobs:
     - name: Checkout code
       uses: actions/checkout@v6
 
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: "20"
+        cache: "npm"
+        cache-dependency-path: ui/package-lock.json
+
     - name: Build UI
-      uses: ./.github/actions/build-ui
+      run: script/build-ui
 
     - name: Set up Go
       uses: actions/setup-go@v6
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -25,8 +25,16 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v6
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+          cache-dependency-path: ui/package-lock.json
+
       - name: Build UI
-        uses: ./.github/actions/build-ui
+        shell: bash
+        run: script/build-ui
 
       - name: Set up Go
         uses: actions/setup-go@v6
diff --git a/.github/workflows/goreleaser.yml b/.github/workflows/goreleaser.yml
@@ -16,8 +16,15 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v6
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+          cache-dependency-path: ui/package-lock.json
+
       - name: Build UI
-        uses: ./.github/actions/build-ui
+        run: script/build-ui
 
       - name: Set up Go
         uses: actions/setup-go@v6
@@ -28,7 +35,7 @@ jobs:
         run: go mod download
 
       - name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@5daf1e915a5f0af01ddbcd89a43b8061ff4f1a89
+        uses: goreleaser/goreleaser-action@e435ccd777264be153ace6237001ef4d979d3a7a
         with:
           distribution: goreleaser
           # GoReleaser version
@@ -40,7 +47,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Generate signed build provenance attestations for workflow artifacts
-        uses: actions/attest-build-provenance@v4
+        uses: actions/attest-build-provenance@v3
         with:
           subject-path: |
             dist/*.tar.gz
diff --git a/.github/workflows/license-check.yml b/.github/workflows/license-check.yml
@@ -32,8 +32,15 @@ jobs:
           GH_TOKEN: ${{ github.token }}
         run: gh pr checkout ${{ github.event.pull_request.number }}
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+          cache-dependency-path: ui/package-lock.json
+
       - name: Build UI
-        uses: ./.github/actions/build-ui
+        run: script/build-ui
 
       - name: Set up Go
         uses: actions/setup-go@v6
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -14,8 +14,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
+      - uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+          cache-dependency-path: ui/package-lock.json
       - name: Build UI
-        uses: ./.github/actions/build-ui
+        run: script/build-ui
       - uses: actions/setup-go@v6
         with:
           go-version: '1.25'
diff --git a/.github/workflows/mcp-diff.yml b/.github/workflows/mcp-diff.yml
@@ -19,8 +19,13 @@ jobs:
         with:
           fetch-depth: 0
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
       - name: Build UI
-        uses: ./.github/actions/build-ui
+        run: script/build-ui
 
       - name: Run MCP Server Diff
         uses: SamMorrowDrums/mcp-server-diff@v2.3.5
@@ -34,6 +39,8 @@ jobs:
             [
               {"name": "default", "args": ""},
               {"name": "read-only", "args": "--read-only"},
+              {"name": "dynamic-toolsets", "args": "--dynamic-toolsets"},
+              {"name": "read-only+dynamic", "args": "--read-only --dynamic-toolsets"},
               {"name": "toolsets-repos", "args": "--toolsets=repos"},
               {"name": "toolsets-issues", "args": "--toolsets=issues"},
               {"name": "toolsets-context", "args": "--toolsets=context"},
@@ -43,7 +50,20 @@ jobs:
               {"name": "toolsets-all", "args": "--toolsets=all"},
               {"name": "tools-get_me", "args": "--tools=get_me"},
               {"name": "tools-get_me,list_issues", "args": "--tools=get_me,list_issues"},
-              {"name": "toolsets-repos+read-only", "args": "--toolsets=repos --read-only"}
+              {"name": "toolsets-repos+read-only", "args": "--toolsets=repos --read-only"},
+              {"name": "toolsets-all+dynamic", "args": "--toolsets=all --dynamic-toolsets"},
+              {"name": "toolsets-repos+dynamic", "args": "--toolsets=repos --dynamic-toolsets"},
+              {"name": "toolsets-repos,issues+dynamic", "args": "--toolsets=repos,issues --dynamic-toolsets"},
+              {
+                "name": "dynamic-tool-calls",
+                "args": "--dynamic-toolsets",
+                "custom_messages": [
+                  {"id": 10, "name": "list_toolsets_before", "message": {"jsonrpc": "2.0", "id": 10, "method": "tools/call", "params": {"name": "list_available_toolsets", "arguments": {}}}},
+                  {"id": 11, "name": "get_toolset_tools", "message": {"jsonrpc": "2.0", "id": 11, "method": "tools/call", "params": {"name": "get_toolset_tools", "arguments": {"toolset": "repos"}}}},
+                  {"id": 12, "name": "enable_toolset", "message": {"jsonrpc": "2.0", "id": 12, "method": "tools/call", "params": {"name": "enable_toolset", "arguments": {"toolset": "repos"}}}},
+                  {"id": 13, "name": "list_toolsets_after", "message": {"jsonrpc": "2.0", "id": 13, "method": "tools/call", "params": {"name": "list_available_toolsets", "arguments": {}}}}
+                ]
+              }
             ]
 
       - name: Add interpretation note
diff --git a/pkg/github/issues_test.go b/pkg/github/issues_test.go
@@ -1186,7 +1186,7 @@ func Test_SearchIssues_FieldValuesEnrichment(t *testing.T) {
 	require.Equal(t, 2, *response.Total)
 	require.Len(t, response.Items, 2)
 	assert.Equal(t, 42, *response.Items[0].Number)
-	assert.Equal(t, []MinimalIssueFieldValue{
+	assert.Equal(t, []MinimalFieldValue{
 		{Field: "priority", Value: "P1"},
 		{Field: "estimate", Value: "2.5"},
 	}, response.Items[0].FieldValues)
@@ -1976,9 +1976,9 @@ func Test_ListIssues(t *testing.T) {
 				// (including float formatting); #789 has no field values.
 				switch issue.Number {
 				case 123:
-					assert.Equal(t, []MinimalIssueFieldValue{{Field: "priority", Value: "P1"}}, issue.FieldValues)
+					assert.Equal(t, []MinimalFieldValue{{Field: "priority", Value: "P1"}}, issue.FieldValues)
 				case 456:
-					assert.Equal(t, []MinimalIssueFieldValue{
+					assert.Equal(t, []MinimalFieldValue{
 						{Field: "due", Value: "2026-06-01"},
 						{Field: "estimate", Value: "2.5"},
 						{Field: "notes", Value: "needs triage"},
