Skip to content

Commit 04976eb

Browse files
authored
tweak comments
1 parent 5eddd33 commit 04976eb

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

pkg/github/issues.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,6 @@ func getCloseStateReason(stateReason string) IssueClosedStateReason {
104104
}
105105

106106
// IssueFieldRef resolves the name of an issue field across its concrete types.
107-
// IssueFields is a union of IssueFieldDate, IssueFieldNumber, IssueFieldSingleSelect, IssueFieldText,
108-
// so we have to ask for `name` on each member.
109107
type IssueFieldRef struct {
110108
Date struct{ Name githubv4.String } `graphql:"... on IssueFieldDate"`
111109
Number struct{ Name githubv4.String } `graphql:"... on IssueFieldNumber"`
@@ -128,8 +126,7 @@ func (r IssueFieldRef) Name() string {
128126
return ""
129127
}
130128

131-
// IssueFieldValueFragment captures the value of a custom issue field. IssueFieldValue is a union
132-
// of 4 concrete value types; each carries its own value scalar and a reference to its parent field.
129+
// IssueFieldValueFragment captures the value of a custom issue field.
133130
// The Number variant's `value` is aliased to `valueNumber` to avoid a Float vs String type clash on decode.
134131
type IssueFieldValueFragment struct {
135132
TypeName string `graphql:"__typename"`
@@ -176,7 +173,7 @@ type IssueFragment struct {
176173
} `graphql:"comments"`
177174
IssueFieldValues struct {
178175
Nodes []IssueFieldValueFragment
179-
} `graphql:"issueFieldValues(first: 25)"` // 25 exceeds the practical max of custom fields per issue in GitHub Projects
176+
} `graphql:"issueFieldValues(first: 25)"` // 25 is the limit set in the monolith
180177
}
181178

182179
// Common interface for all issue query types

0 commit comments

Comments
 (0)