From 25bde03dfb4cd87f885c4e5bddd3c22809556249 Mon Sep 17 00:00:00 2001 From: "Michael B. Gale" Date: Tue, 24 Feb 2026 11:18:51 +0000 Subject: [PATCH] Remove FF gate for connection checks --- lib/analyze-action-post.js | 5 ----- lib/analyze-action.js | 5 ----- lib/autobuild-action.js | 5 ----- lib/init-action-post.js | 5 ----- lib/init-action.js | 5 ----- lib/resolve-environment-action.js | 5 ----- lib/setup-codeql-action.js | 5 ----- lib/start-proxy-action-post.js | 5 ----- lib/start-proxy-action.js | 9 +-------- lib/upload-lib.js | 5 ----- lib/upload-sarif-action-post.js | 5 ----- lib/upload-sarif-action.js | 5 ----- src/feature-flags.ts | 6 ------ src/start-proxy-action.ts | 4 +--- 14 files changed, 2 insertions(+), 72 deletions(-) diff --git a/lib/analyze-action-post.js b/lib/analyze-action-post.js index d1068dc55e..852e31053e 100644 --- a/lib/analyze-action-post.js +++ b/lib/analyze-action-post.js @@ -161736,11 +161736,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/lib/analyze-action.js b/lib/analyze-action.js index d97d19c515..0e1ee13b9e 100644 --- a/lib/analyze-action.js +++ b/lib/analyze-action.js @@ -107847,11 +107847,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/lib/autobuild-action.js b/lib/autobuild-action.js index d39e634000..6bd66e118e 100644 --- a/lib/autobuild-action.js +++ b/lib/autobuild-action.js @@ -104137,11 +104137,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/lib/init-action-post.js b/lib/init-action-post.js index f4bc19ecf9..cdc39592a1 100644 --- a/lib/init-action-post.js +++ b/lib/init-action-post.js @@ -165214,11 +165214,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/lib/init-action.js b/lib/init-action.js index ca0b47a854..2aae2eb015 100644 --- a/lib/init-action.js +++ b/lib/init-action.js @@ -105364,11 +105364,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/lib/resolve-environment-action.js b/lib/resolve-environment-action.js index 93eee7f4c4..9a307ab432 100644 --- a/lib/resolve-environment-action.js +++ b/lib/resolve-environment-action.js @@ -104128,11 +104128,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/lib/setup-codeql-action.js b/lib/setup-codeql-action.js index 95a380ab4b..009dc8864f 100644 --- a/lib/setup-codeql-action.js +++ b/lib/setup-codeql-action.js @@ -104037,11 +104037,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/lib/start-proxy-action-post.js b/lib/start-proxy-action-post.js index 76abe6d2f3..595aefb138 100644 --- a/lib/start-proxy-action-post.js +++ b/lib/start-proxy-action-post.js @@ -161142,11 +161142,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/lib/start-proxy-action.js b/lib/start-proxy-action.js index e7d3871203..74f4288329 100644 --- a/lib/start-proxy-action.js +++ b/lib/start-proxy-action.js @@ -120829,11 +120829,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", @@ -122152,9 +122147,7 @@ async function run(startedAt) { proxyLogFilePath, logger ); - if (await features.getValue("start_proxy_connection_checks" /* StartProxyConnectionChecks */)) { - await checkConnections(logger, proxyInfo); - } + await checkConnections(logger, proxyInfo); await sendSuccessStatusReport( startedAt, { diff --git a/lib/upload-lib.js b/lib/upload-lib.js index fcec315ba3..43a8d175a4 100644 --- a/lib/upload-lib.js +++ b/lib/upload-lib.js @@ -107296,11 +107296,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/lib/upload-sarif-action-post.js b/lib/upload-sarif-action-post.js index 707ab28353..2bd07ac786 100644 --- a/lib/upload-sarif-action-post.js +++ b/lib/upload-sarif-action-post.js @@ -161304,11 +161304,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/lib/upload-sarif-action.js b/lib/upload-sarif-action.js index 071fe3b0ca..15c345cc03 100644 --- a/lib/upload-sarif-action.js +++ b/lib/upload-sarif-action.js @@ -107021,11 +107021,6 @@ var featureConfig = { // cannot be found when interpreting results. minimumVersion: void 0 }, - ["start_proxy_connection_checks" /* StartProxyConnectionChecks */]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: void 0 - }, ["upload_overlay_db_to_api" /* UploadOverlayDbToApi */]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/src/feature-flags.ts b/src/feature-flags.ts index f2a6c90a21..6eb8dcfc3b 100644 --- a/src/feature-flags.ts +++ b/src/feature-flags.ts @@ -75,7 +75,6 @@ export enum Feature { QaTelemetryEnabled = "qa_telemetry_enabled", /** Note that this currently only disables baseline file coverage information. */ SkipFileCoverageOnPrs = "skip_file_coverage_on_prs", - StartProxyConnectionChecks = "start_proxy_connection_checks", UploadOverlayDbToApi = "upload_overlay_db_to_api", UseRepositoryProperties = "use_repository_properties_v2", ValidateDbConfig = "validate_db_config", @@ -316,11 +315,6 @@ export const featureConfig = { // cannot be found when interpreting results. minimumVersion: undefined, }, - [Feature.StartProxyConnectionChecks]: { - defaultValue: false, - envVar: "CODEQL_ACTION_START_PROXY_CONNECTION_CHECKS", - minimumVersion: undefined, - }, [Feature.UploadOverlayDbToApi]: { defaultValue: false, envVar: "CODEQL_ACTION_UPLOAD_OVERLAY_DB_TO_API", diff --git a/src/start-proxy-action.ts b/src/start-proxy-action.ts index df6c9a3328..9ff0f8529f 100644 --- a/src/start-proxy-action.ts +++ b/src/start-proxy-action.ts @@ -109,9 +109,7 @@ async function run(startedAt: Date) { ); // Check that the private registries are reachable. - if (await features.getValue(Feature.StartProxyConnectionChecks)) { - await checkConnections(logger, proxyInfo); - } + await checkConnections(logger, proxyInfo); // Report success if we have reached this point. await sendSuccessStatusReport(