Fixed: Split-stereo files were not combined into stereo files for formats which require it (e.g. Bento).

Author: git-moss

documentation/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changes
 
+## 15.5.1
+
+* Fixed: Split-stereo files were not combined into stereo files for formats which require it (e.g. Bento).
+
 ## 15.5.0
 
 * Added support for 1010music Bento

pom.xml

@@ -5,7 +5,7 @@
 	<modelVersion>4.0.0</modelVersion>
 	<groupId>de.mossgrabers</groupId>
 	<artifactId>convertwithmoss</artifactId>
-	<version>15.5.0</version>
+	<version>15.5.1</version>
 	<packaging>jar</packaging>
 	<name>ConvertWithMoss</name>
 	<organization>

src/main/java/de/mossgrabers/convertwithmoss/core/ZoneChannels.java

@@ -81,7 +81,7 @@ public static ZoneChannels detectChannelConfiguration (final List<IGroup> groups
                     // Check for split stereo which needs to be hard panned left or right
                     if (!isStereo && (splitStereo == null || splitStereo.booleanValue ()))
                     {
-                        final double panning = sampleZone.getTuning ();
+                        final double panning = sampleZone.getPanning ();
                         splitStereo = Boolean.valueOf (panning <= -1 || panning >= 1);
                     }
                 }
@@ -183,7 +183,7 @@ private static void getSplitStereo (final List<IGroup> groups, final List<ISampl
     {
         for (final IGroup group: groups)
             for (final ISampleZone sampleZone: group.getSampleZones ())
-                if (sampleZone.getTuning () <= -1)
+                if (sampleZone.getPanning () <= -1)
                     leftSampleZones.add (sampleZone);
                 else
                     rightSampleZones.add (sampleZone);

src/main/java/de/mossgrabers/convertwithmoss/format/music1010/bento/BentoCreator.java

@@ -327,22 +327,6 @@ private Optional<String> createPreset (final List<IInstrumentSource> instrumentS
                 paramsElement.setAttribute (entry.getKey (), entry.getValue ());
             paramsElement.setAttribute (Music1010Tag.ATTR_INTERPOLATION_QUALITY, this.settingsConfiguration.isInterpolationQualityHigh () ? "1" : "0");
 
-            // TODO Ask 1010music about these 3 parameters:
-
-            // The following parameters (panning, gain and pitch) are only available on instrument
-            // level
-            // Panning: -100..100% -> -1000..1000
-            // final Optional<Double> globalPanning = multisampleSource.getGlobalPanning ();
-            // if (globalPanning.isPresent ())
-            // paramsElement.setAttribute (Music1010Tag.ATTR_PANNING, Integer.toString ((int)
-            // Math.clamp (globalPanning.get ().doubleValue () * 1000.0, -1000.0, 1000.0)));
-
-            // -12..12dB -> -12000..12000
-            // gaindb="4300"
-            // -24..24 -> -24000..24000
-            // pitch="-19350"
-            // panpos="-352"
-
             // Add amplitude envelope
             if (!groups.isEmpty ())
             {
@@ -448,6 +432,17 @@ private void createSample (final Document document, final String presetPath, fin
         final String filename = this.createSampleFilename (zone, 0, ".wav");
         paramsElement.setAttribute (Music1010Tag.ATTR_FILENAME, presetPath + filename);
 
+        // IMPROVE The following parameters (panning, gain and pitch) are only available on
+        // instrument level (1010music needs to implement it on sample level first)
+        // Panning: -100..100% -> -1000..1000
+        // paramsElement.setAttribute (Music1010Tag.ATTR_PANNING, Integer.toString ((int) Math.clamp
+        // (zone.getPanning () * 1000.0, -1000.0, 1000.0)));
+        // -12..12dB -> -12000..12000
+        // gaindb="4300"
+        // -24..24 -> -24000..24000
+        // pitch="-19350"
+        // panpos="-352"
+
         /////////////////////////////////////////////////////
         // Key & Velocity attributes
 

src/main/resources/Strings.properties

@@ -1,4 +1,4 @@
-TITLE=ConvertWithMoss 15.5.0
+TITLE=ConvertWithMoss 15.5.1
 
 ##################################################################################
 #