Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/sentry_rails_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,12 @@ jobs:
rails_version: "8.0.0"
- ruby_version: "3.4"
rails_version: "8.0.0"
- ruby_version: "4.0"
rails_version: "8.0.0"
- ruby_version: "3.4"
rails_version: "8.1.0"
rails_version: "8.1.3"
- ruby_version: "4.0"
rails_version: "8.1.3"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing exclude entries for Ruby 4.0 with older Rails

Medium Severity

Ruby "4.0" is added to the include entries but no corresponding exclude entries are added. The base matrix crosses ruby_version (from inputs.versions, which will include "4.0") with rails_version: [6.1.0, 7.0.0, 7.1.0]. Ruby "3.4" is already excluded from 6.1.0 and 7.0.0 for compatibility reasons, but Ruby "4.0" is not — resulting in CI jobs for 4.0 × 6.1.0 and 4.0 × 7.0.0 (and likely 4.0 × 7.1.0) that will fail due to incompatibility.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d74dfa8. Configure here.

- ruby_version: "3.2"
rails_version: 7.1.0
options:
Expand Down
Loading