From a710eb3f1d39f7a120deb108149ed7fb4486b9d7 Mon Sep 17 00:00:00 2001 From: Alexander Alderman Webb Date: Wed, 20 May 2026 08:46:26 +0200 Subject: [PATCH] fix(cohere): Stop setting transaction status when child span fails --- sentry_sdk/integrations/cohere.py | 5 +---- tests/integrations/cohere/test_cohere.py | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sentry_sdk/integrations/cohere.py b/sentry_sdk/integrations/cohere.py index a88f16ffb1..065865062f 100644 --- a/sentry_sdk/integrations/cohere.py +++ b/sentry_sdk/integrations/cohere.py @@ -6,7 +6,6 @@ from sentry_sdk.ai.monitoring import record_token_usage from sentry_sdk.ai.utils import get_start_span_function, set_data_normalized from sentry_sdk.consts import SPANDATA -from sentry_sdk.tracing_utils import set_span_errored if TYPE_CHECKING: from typing import Any, Callable, Iterator @@ -83,8 +82,6 @@ def setup_once() -> None: def _capture_exception(exc: "Any") -> None: - set_span_errored() - event, hint = event_from_exception( exc, client_options=sentry_sdk.get_client().options, @@ -154,7 +151,7 @@ def new_chat(*args: "Any", **kwargs: "Any") -> "Any": exc_info = sys.exc_info() with capture_internal_exceptions(): _capture_exception(e) - span.__exit__(None, None, None) + span.__exit__(*exc_info) reraise(*exc_info) with capture_internal_exceptions(): diff --git a/tests/integrations/cohere/test_cohere.py b/tests/integrations/cohere/test_cohere.py index 8c26ac0a91..c4ff4af20d 100644 --- a/tests/integrations/cohere/test_cohere.py +++ b/tests/integrations/cohere/test_cohere.py @@ -183,7 +183,6 @@ def test_span_status_error(sentry_init, capture_events): assert error["level"] == "error" assert transaction["spans"][0]["status"] == "internal_error" assert transaction["spans"][0]["tags"]["status"] == "internal_error" - assert transaction["contexts"]["trace"]["status"] == "internal_error" @pytest.mark.parametrize(