Address CR comments

Author: ericapisani

sentry_sdk/integrations/strawberry.py

@@ -8,6 +8,7 @@
 from sentry_sdk.integrations import DidNotEnable, Integration, _check_minimum_version
 from sentry_sdk.integrations.logging import ignore_logger
 from sentry_sdk.scope import should_send_default_pii
+from sentry_sdk.traces import SegmentSource
 from sentry_sdk.tracing import Span, TransactionSource
 from sentry_sdk.tracing_utils import StreamedSpan, has_span_streaming_enabled
 from sentry_sdk.utils import (
@@ -181,8 +182,7 @@ def on_operation(self) -> "Generator[None, None, None]":
         )
 
         scope = sentry_sdk.get_isolation_scope()
-        execution_context = self.execution_context
-        event_processor = _make_request_event_processor(execution_context)
+        event_processor = _make_request_event_processor(self.execution_context)
         scope.add_event_processor(event_processor)
 
         client = sentry_sdk.get_client()
@@ -191,7 +191,7 @@ def on_operation(self) -> "Generator[None, None, None]":
             additional_attributes: "dict[str, Any]" = {}
 
             if should_send_default_pii():
-                additional_attributes["graphql.document"] = execution_context.query
+                additional_attributes["graphql.document"] = self.execution_context.query
 
             if operation_name:
                 additional_attributes["graphql.operation.name"] = operation_name
@@ -211,12 +211,11 @@ def on_operation(self) -> "Generator[None, None, None]":
                 name=description,
                 origin=StrawberryIntegration.origin,
             )
-
-        graphql_span.__enter__()
+            graphql_span.__enter__()
 
         if type(graphql_span) is Span:
             if should_send_default_pii():
-                graphql_span.set_data("graphql.document", execution_context.query)
+                graphql_span.set_data("graphql.document", self.execution_context.query)
 
             graphql_span.set_data("graphql.operation.type", operation_type)
             graphql_span.set_data("graphql.operation.name", operation_name)
@@ -226,15 +225,15 @@ def on_operation(self) -> "Generator[None, None, None]":
         yield
 
         if type(graphql_span) is StreamedSpan:
-            if execution_context.operation_name:
+            if self.execution_context.operation_name:
                 segment = graphql_span._segment
-                segment.set_attribute("sentry.span.source", TransactionSource.COMPONENT)
+                segment.set_attribute("sentry.span.source", SegmentSource.COMPONENT)
                 segment.set_attribute("sentry.op", op)
-                segment.name = execution_context.operation_name
+                segment.name = self.execution_context.operation_name
         elif isinstance(graphql_span, Span):
             transaction = graphql_span.containing_transaction
-            if transaction and execution_context.operation_name:
-                transaction.name = execution_context.operation_name
+            if transaction and self.execution_context.operation_name:
+                transaction.name = self.execution_context.operation_name
                 transaction.source = TransactionSource.COMPONENT
                 transaction.op = op
 
@@ -261,7 +260,7 @@ def on_validate(self) -> "Generator[None, None, None]":
 
         yield
 
-        if is_span_streaming_enabled and isinstance(validation_span, StreamedSpan):
+        if isinstance(validation_span, StreamedSpan):
             validation_span.end()
         else:
             validation_span.finish()
@@ -287,7 +286,7 @@ def on_parse(self) -> "Generator[None, None, None]":
 
         yield
 
-        if is_span_streaming_enabled and isinstance(parsing_span, StreamedSpan):
+        if isinstance(parsing_span, StreamedSpan):
             parsing_span.end()
         else:
             parsing_span.finish()