Skip to content

Commit ede0537

Browse files
ericapisaniericapisani
committed
Change name of segment to not be transaction
1 parent 2c3579b commit ede0537

1 file changed

Lines changed: 22 additions & 22 deletions

File tree

‎tests/integrations/asyncpg/test_asyncpg.py‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@ async def test_query_source_disabled(
547547

548548
if span_streaming:
549549
items = capture_items("span")
550-
with sentry_sdk.traces.start_span(name="test_transaction"):
550+
with sentry_sdk.traces.start_span(name="test_segment"):
551551
conn: Connection = await connect(PG_CONNECTION_URI)
552552

553553
await conn.execute(
@@ -565,7 +565,7 @@ async def test_query_source_disabled(
565565
insert_span = spans[1]
566566
segment = spans[2]
567567

568-
assert segment["name"] == "test_transaction"
568+
assert segment["name"] == "test_segment"
569569
assert insert_span["name"].startswith("INSERT INTO")
570570
assert connect_span["name"] == "connect"
571571
data = insert_span.get("attributes", {})
@@ -613,7 +613,7 @@ async def test_query_source_enabled(
613613

614614
if span_streaming:
615615
items = capture_items("span")
616-
with sentry_sdk.traces.start_span(name="test_transaction"):
616+
with sentry_sdk.traces.start_span(name="test_segment"):
617617
conn: Connection = await connect(PG_CONNECTION_URI)
618618

619619
await conn.execute(
@@ -631,7 +631,7 @@ async def test_query_source_enabled(
631631
insert_span = spans[1]
632632
segment = spans[2]
633633

634-
assert segment["name"] == "test_transaction"
634+
assert segment["name"] == "test_segment"
635635
assert insert_span["name"].startswith("INSERT INTO")
636636
assert connect_span["name"] == "connect"
637637
data = insert_span.get("attributes", {})
@@ -676,7 +676,7 @@ async def test_query_source(sentry_init, capture_events, capture_items, span_str
676676

677677
if span_streaming:
678678
items = capture_items("span")
679-
with sentry_sdk.traces.start_span(name="test_transaction"):
679+
with sentry_sdk.traces.start_span(name="test_segment"):
680680
conn: Connection = await connect(PG_CONNECTION_URI)
681681

682682
await conn.execute(
@@ -694,7 +694,7 @@ async def test_query_source(sentry_init, capture_events, capture_items, span_str
694694
insert_span = spans[1]
695695
segment = spans[2]
696696

697-
assert segment["name"] == "test_transaction"
697+
assert segment["name"] == "test_segment"
698698
assert insert_span["name"].startswith("INSERT INTO")
699699
assert connect_span["name"] == "connect"
700700
data = insert_span.get("attributes", {})
@@ -758,7 +758,7 @@ async def test_query_source_with_module_in_search_path(
758758

759759
if span_streaming:
760760
items = capture_items("span")
761-
with sentry_sdk.traces.start_span(name="test_transaction"):
761+
with sentry_sdk.traces.start_span(name="test_segment"):
762762
conn: Connection = await connect(PG_CONNECTION_URI)
763763

764764
await execute_query_in_connection(
@@ -777,7 +777,7 @@ async def test_query_source_with_module_in_search_path(
777777
insert_span = spans[1]
778778
segment = spans[2]
779779

780-
assert segment["name"] == "test_transaction"
780+
assert segment["name"] == "test_segment"
781781
assert insert_span["name"].startswith("INSERT INTO")
782782
assert connect_span["name"] == "connect"
783783
data = insert_span.get("attributes", {})
@@ -848,7 +848,7 @@ def fake_record_sql_queries_streaming(*args, **kwargs):
848848
span._timestamp = datetime.datetime(2024, 1, 1, microsecond=99999)
849849
yield span
850850

851-
with sentry_sdk.traces.start_span(name="test_transaction"):
851+
with sentry_sdk.traces.start_span(name="test_segment"):
852852
conn: Connection = await connect(PG_CONNECTION_URI)
853853

854854
with mock.patch(
@@ -870,7 +870,7 @@ def fake_record_sql_queries_streaming(*args, **kwargs):
870870
insert_span = spans[1]
871871
segment = spans[2]
872872

873-
assert segment["name"] == "test_transaction"
873+
assert segment["name"] == "test_segment"
874874
assert insert_span["name"].startswith("INSERT INTO")
875875
assert connect_span["name"] == "connect"
876876
data = insert_span.get("attributes", {})
@@ -985,7 +985,7 @@ async def test_span_origin(sentry_init, capture_events, capture_items, span_stre
985985

986986
if span_streaming:
987987
items = capture_items("span")
988-
with sentry_sdk.traces.start_span(name="test_transaction"):
988+
with sentry_sdk.traces.start_span(name="test_segment"):
989989
conn: Connection = await connect(PG_CONNECTION_URI)
990990

991991
await conn.execute("SELECT 1")
@@ -1002,7 +1002,7 @@ async def test_span_origin(sentry_init, capture_events, capture_items, span_stre
10021002
select2_span = spans[2]
10031003
segment = spans[3]
10041004

1005-
assert segment["name"] == "test_transaction"
1005+
assert segment["name"] == "test_segment"
10061006
assert connect_span["name"] == "connect"
10071007
assert select1_span["name"] == "SELECT 1"
10081008
assert select2_span["name"] == "SELECT 2"
@@ -1044,7 +1044,7 @@ async def test_multiline_query_description_normalized(
10441044

10451045
if span_streaming:
10461046
items = capture_items("span")
1047-
with sentry_sdk.traces.start_span(name="test_transaction"):
1047+
with sentry_sdk.traces.start_span(name="test_segment"):
10481048
conn: Connection = await connect(PG_CONNECTION_URI)
10491049
await conn.execute(
10501050
"""
@@ -1068,7 +1068,7 @@ async def test_multiline_query_description_normalized(
10681068
select_span = spans[1]
10691069
segment = spans[2]
10701070

1071-
assert segment["name"] == "test_transaction"
1071+
assert segment["name"] == "test_segment"
10721072
assert connect_span["name"] == "connect"
10731073
assert select_span["name"] == "SELECT id, name FROM users WHERE name = 'Alice'"
10741074
else:
@@ -1184,7 +1184,7 @@ async def test_query_source_execute(
11841184

11851185
if span_streaming:
11861186
items = capture_items("span")
1187-
with sentry_sdk.traces.start_span(name="test_transaction"):
1187+
with sentry_sdk.traces.start_span(name="test_segment"):
11881188
conn: Connection = await connect(PG_CONNECTION_URI)
11891189
await conn.execute(
11901190
"INSERT INTO users(name, password, dob) VALUES($1, $2, $3)",
@@ -1204,7 +1204,7 @@ async def test_query_source_execute(
12041204

12051205
assert connect_span["name"] == "connect"
12061206
assert query_span["name"].startswith("INSERT INTO")
1207-
assert segment["name"] == "test_transaction"
1207+
assert segment["name"] == "test_segment"
12081208
assert segment["is_segment"] is True
12091209
else:
12101210
events = capture_events()
@@ -1245,7 +1245,7 @@ async def test_query_source_executemany(
12451245

12461246
if span_streaming:
12471247
items = capture_items("span")
1248-
with sentry_sdk.traces.start_span(name="test_transaction"):
1248+
with sentry_sdk.traces.start_span(name="test_segment"):
12491249
conn: Connection = await connect(PG_CONNECTION_URI)
12501250
await conn.executemany(
12511251
"INSERT INTO users(name, password, dob) VALUES($1, $2, $3)",
@@ -1263,7 +1263,7 @@ async def test_query_source_executemany(
12631263

12641264
assert connect_span["name"] == "connect"
12651265
assert query_span["name"].startswith("INSERT INTO")
1266-
assert segment["name"] == "test_transaction"
1266+
assert segment["name"] == "test_segment"
12671267
else:
12681268
events = capture_events()
12691269
with start_transaction(name="test_transaction", sampled=True):
@@ -1301,7 +1301,7 @@ async def test_query_source_prepare(
13011301

13021302
if span_streaming:
13031303
items = capture_items("span")
1304-
with sentry_sdk.traces.start_span(name="test_transaction"):
1304+
with sentry_sdk.traces.start_span(name="test_segment"):
13051305
conn: Connection = await connect(PG_CONNECTION_URI)
13061306
await conn.prepare("SELECT * FROM users WHERE name = $1")
13071307
await conn.close()
@@ -1315,7 +1315,7 @@ async def test_query_source_prepare(
13151315

13161316
assert connect_span["name"] == "connect"
13171317
assert query_span["name"] == "SELECT * FROM users WHERE name = $1"
1318-
assert segment["name"] == "test_transaction"
1318+
assert segment["name"] == "test_segment"
13191319
else:
13201320
events = capture_events()
13211321
with start_transaction(name="test_transaction", sampled=True):
@@ -1354,7 +1354,7 @@ async def test_cursor__bind_exec_creates_spans(
13541354

13551355
if span_streaming:
13561356
items = capture_items("span")
1357-
with sentry_sdk.traces.start_span(name="test_transaction"):
1357+
with sentry_sdk.traces.start_span(name="test_segment"):
13581358
conn: Connection = await connect(PG_CONNECTION_URI)
13591359

13601360
await conn.executemany(
@@ -1394,7 +1394,7 @@ async def test_cursor__bind_exec_creates_spans(
13941394
assert begin_span["name"] == "BEGIN;"
13951395
assert bind_exec_span["name"] == "SELECT * FROM users WHERE dob > $1"
13961396
assert commit_span["name"] == "COMMIT;"
1397-
assert segment["name"] == "test_transaction"
1397+
assert segment["name"] == "test_segment"
13981398

13991399
assert bind_exec_span["attributes"]["sentry.origin"] == "auto.db.asyncpg"
14001400
assert bind_exec_span["attributes"]["sentry.op"] == "db"

0 commit comments

Comments
 (0)