Skip to content

Commit bc41a1d

Browse files
.
1 parent 55cf5ec commit bc41a1d

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

CONTRIBUTING.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,9 +173,6 @@ What's the concrete advice when writing a new integration?
173173
- Dead code adds cognitive overhead when reasoning about code, so don't account for impossible scenarios.
174174

175175
11. Write tests, but don't write mocks.
176-
- You'd be surprised how many tests assert the wrong thing.
177-
- Others packaging the SDK seem to run our test suite, so don't write racy or other environment-dependent tests.
178-
- Don't test unreachable states, or your tests will be removed.
179176
- Don't call private SDK stuff directly, just use the patched library in a way that triggers the patch.
180177
- Mocks are _very expensive_ to maintain, particularly when testing patches for fast-moving libraries.
181178
- Consider the minimum versions supported, and document in `_MIN_VERSIONS` in `integrations/__init__.py`.

0 commit comments

Comments
 (0)