.

Author: sentrivana

tests/integrations/redis/asyncio/test_redis_asyncio.py

@@ -81,6 +81,7 @@ async def test_async_redis_pipeline(
         attrs = pipeline_span["attributes"]
         assert attrs["sentry.op"] == "db.redis"
         assert attrs["db.system.name"] == "redis-py"
+        assert attrs[SPANDATA.DB_DRIVER_NAME] == "redis-py"
         assert attrs["db.namespace"] == "0"
         assert attrs[SPANDATA.SERVER_ADDRESS] == (
             connection.connection_pool.connection_kwargs.get("host")

tests/integrations/redis/cluster/test_redis_cluster.py

@@ -98,6 +98,7 @@ def test_rediscluster_basic(
         attrs = span["attributes"]
         assert attrs["sentry.op"] == "db.redis"
         assert attrs["db.system.name"] == "redis-py"
+        assert attrs[SPANDATA.DB_DRIVER_NAME] == "redis-py"
         # ClusterNode converts localhost to 127.0.0.1
         assert attrs[SPANDATA.SERVER_ADDRESS] == "127.0.0.1"
         assert attrs[SPANDATA.SERVER_PORT] == 6379
@@ -184,6 +185,7 @@ def test_rediscluster_pipeline(
         attrs = pipeline_span["attributes"]
         assert attrs["sentry.op"] == "db.redis"
         assert attrs["db.system.name"] == "redis-py"
+        assert attrs[SPANDATA.DB_DRIVER_NAME] == "redis-py"
         # ClusterNode converts localhost to 127.0.0.1
         assert attrs[SPANDATA.SERVER_ADDRESS] == "127.0.0.1"
         assert attrs[SPANDATA.SERVER_PORT] == 6379

tests/integrations/redis/cluster_asyncio/test_redis_cluster_asyncio.py

@@ -102,6 +102,7 @@ async def test_async_basic(
         attrs = redis_span["attributes"]
         assert attrs["sentry.op"] == "db.redis"
         assert attrs["db.system.name"] == "redis-py"
+        assert attrs[SPANDATA.DB_DRIVER_NAME] == "redis-py"
         assert attrs[SPANDATA.SERVER_ADDRESS] == "127.0.0.1"
         assert attrs[SPANDATA.SERVER_PORT] == 6379
         assert attrs["db.operation.name"] == "SET"
@@ -175,6 +176,7 @@ async def test_async_redis_pipeline(
         attrs = pipeline_span["attributes"]
         assert attrs["sentry.op"] == "db.redis"
         assert attrs["db.system.name"] == "redis-py"
+        assert attrs[SPANDATA.DB_DRIVER_NAME] == "redis-py"
         assert attrs[SPANDATA.SERVER_ADDRESS] == "127.0.0.1"
         assert attrs[SPANDATA.SERVER_PORT] == 6379
     else:

tests/integrations/redis/test_redis.py

@@ -88,7 +88,7 @@ def test_redis_pipeline(
         assert pipeline_span["name"] == "redis.pipeline.execute"
         assert pipeline_span["attributes"]["sentry.op"] == "db.redis"
         assert pipeline_span["attributes"]["sentry.origin"] == "auto.db.redis"
-        assert pipeline_span["attributes"]["db.system.name"] == "redis-py"
+        assert pipeline_span["attributes"]["db.system.name"] == "redis"
     else:
         events = capture_events()
         with start_transaction():
@@ -402,7 +402,7 @@ def test_db_connection_attributes_client(
         assert redis_span["name"] == "GET 'foobar'"
         attrs = redis_span["attributes"]
         assert attrs["sentry.op"] == "db.redis"
-        assert attrs["db.system.name"] == "redis-py"
+        assert attrs["db.system.name"] == "redis"
         assert attrs[SPANDATA.DB_DRIVER_NAME] == "redis-py"
         assert attrs["db.namespace"] == "1"
         assert attrs[SPANDATA.SERVER_ADDRESS] == "localhost"
@@ -453,8 +453,8 @@ def test_db_connection_attributes_pipeline(
         assert pipeline_span["name"] == "redis.pipeline.execute"
         attrs = pipeline_span["attributes"]
         assert attrs["sentry.op"] == "db.redis"
-        assert attrs["db.system.name"] == "redis-py"
-        assert attrs[SPANDATA.DB_DRIVER_NAME] == "redis"
+        assert attrs["db.system.name"] == "redis"
+        assert attrs[SPANDATA.DB_DRIVER_NAME] == "redis-py"
         assert attrs["db.namespace"] == "1"
         assert attrs[SPANDATA.SERVER_ADDRESS] == "localhost"
         assert attrs[SPANDATA.SERVER_PORT] == 63791