Skip to content

Commit 30ba6da

Browse files
committed
address bot comments
1 parent 04bf803 commit 30ba6da

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

sentry_sdk/integrations/pymongo.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,10 @@ def started(self, event: "CommandStartedEvent") -> None:
141141

142142
db_data = _get_db_data(event)
143143

144+
collection_name = command.get(event.command_name)
145+
operation_name = event.command_name
146+
db_name = event.database_name
147+
144148
lsid = command.pop("lsid", None)
145149
if not should_send_default_pii():
146150
command = _strip_pii(command)
@@ -149,11 +153,8 @@ def started(self, event: "CommandStartedEvent") -> None:
149153

150154
if has_span_streaming_enabled(client.options):
151155
span_first_data = {
152-
"db.namespace": event.database_name,
153-
"db.system.name": "mongodb",
154-
SPANDATA.DB_DRIVER_NAME: "pymongo",
155-
"db.operation.name": event.command_name,
156-
"db.collection.name": command.get(event.command_name),
156+
"db.operation.name": operation_name,
157+
"db.collection.name": collection_name,
157158
"sentry.op": OP.DB,
158159
"sentry.origin": PyMongoIntegration.origin,
159160
**db_data,
@@ -173,13 +174,13 @@ def started(self, event: "CommandStartedEvent") -> None:
173174

174175
else:
175176
tags = {
176-
"db.name": event.database_name,
177+
"db.name": db_name,
177178
SPANDATA.DB_SYSTEM: "mongodb",
178179
SPANDATA.DB_DRIVER_NAME: "pymongo",
179-
SPANDATA.DB_OPERATION: event.command_name,
180+
SPANDATA.DB_OPERATION: operation_name,
180181
# The below is a deprecated field, but leaving for legacy reasons.
181182
# The v2 spans will use `db.collection.name` instead.
182-
SPANDATA.DB_MONGODB_COLLECTION: command.get(event.command_name),
183+
SPANDATA.DB_MONGODB_COLLECTION: collection_name,
183184
}
184185

185186
try:

0 commit comments

Comments
 (0)