From 74bbb09634552ada7ec1e4b6a53977bf8b2a94f6 Mon Sep 17 00:00:00 2001 From: Francesco Gringl-Novy Date: Tue, 12 May 2026 13:24:52 +0200 Subject: [PATCH 1/2] ci(remix): Do not run playwright install again for remix --- packages/remix/package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/remix/package.json b/packages/remix/package.json index 6ca31101f661..09e1b3ee5608 100644 --- a/packages/remix/package.json +++ b/packages/remix/package.json @@ -107,11 +107,11 @@ "lint:es-compatibility": "es-check es2020 ./build/cjs/*.js && es-check es2020 ./build/esm/*.js --module", "test": "yarn test:unit", "test:integration": "run-s test:integration:clean test:integration:prepare test:integration:client test:integration:server", - "test:integration:ci": "run-s test:integration:clean test:integration:prepare test:integration:client:ci test:integration:server", + "test:integration:ci": "run-s test:integration:clean test:integration:prepare test:integration:client test:integration:server", "test:integration:prepare": "(cd test/integration && yarn install)", + "test:integration:prepare:playwright": "yarn playwright install-deps", "test:integration:clean": "(cd test/integration && rimraf .cache node_modules build)", - "test:integration:client": "yarn playwright install-deps && yarn playwright test test/integration/test/client/ --project='chromium'", - "test:integration:client:ci": "yarn test:integration:client", + "test:integration:client": "yarn playwright test test/integration/test/client/ --project='chromium'", "test:integration:server": "export NODE_OPTIONS='--stack-trace-limit=25' && vitest run", "test:unit": "vitest run --config vitest.config.unit.ts", "test:watch": "vitest --watch --config vitest.config.unit.ts", From 586c96604ddee394c9b8d5684999f4ddebd7df7c Mon Sep 17 00:00:00 2001 From: Francesco Gringl-Novy Date: Tue, 12 May 2026 13:57:22 +0200 Subject: [PATCH 2/2] remove duplicate command --- .github/workflows/build.yml | 5 ++--- packages/remix/package.json | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2d7781c5f43f..2a7e1dd97555 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -925,9 +925,8 @@ jobs: - name: Run integration tests env: NODE_VERSION: ${{ matrix.node }} - run: | - cd packages/remix - yarn test:integration:ci + working-directory: packages/remix + run: yarn test:integration job_build_tarballs: name: Build tarballs diff --git a/packages/remix/package.json b/packages/remix/package.json index 09e1b3ee5608..c1fb15780683 100644 --- a/packages/remix/package.json +++ b/packages/remix/package.json @@ -107,7 +107,6 @@ "lint:es-compatibility": "es-check es2020 ./build/cjs/*.js && es-check es2020 ./build/esm/*.js --module", "test": "yarn test:unit", "test:integration": "run-s test:integration:clean test:integration:prepare test:integration:client test:integration:server", - "test:integration:ci": "run-s test:integration:clean test:integration:prepare test:integration:client test:integration:server", "test:integration:prepare": "(cd test/integration && yarn install)", "test:integration:prepare:playwright": "yarn playwright install-deps", "test:integration:clean": "(cd test/integration && rimraf .cache node_modules build)",