Skip to content

Commit 90b045f

Browse files
committed
address comments
1 parent 70737db commit 90b045f

49 files changed

Lines changed: 886 additions & 401 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

dev-packages/e2e-tests/test-applications/ember-classic/app/app.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,6 @@ Sentry.init({
1010
tracesSampleRate: 1,
1111
replaysSessionSampleRate: 1,
1212
replaysOnErrorSampleRate: 1,
13-
browserTracingOptions: {
14-
_experiments: {
15-
// Long-task spans are noisy in e2e and make assertions flaky.
16-
enableLongTask: false,
17-
},
18-
},
1913
tracePropagationTargets: ['localhost', 'doesntexist.example'],
2014
tunnel: `http://localhost:3031/`, // proxy server
2115
});

dev-packages/e2e-tests/test-applications/ember-classic/app/index.html

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
<meta name="description" content="" />
77
<meta name="viewport" content="width=device-width, initial-scale=1" />
88

9-
<script>if(window.performance&&window.performance.mark){window.performance.mark('@sentry/ember:initial-load-start');}</script>
10-
119
{{content-for "head"}}
1210

1311
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css" />
@@ -21,8 +19,6 @@
2119
<script src="{{rootURL}}assets/vendor.js"></script>
2220
<script src="{{rootURL}}assets/ember-classic.js"></script>
2321

24-
<script>if(window.performance&&window.performance.mark){window.performance.mark('@sentry/ember:initial-load-end');}</script>
25-
2622
{{content-for "body-footer"}}
2723
</body>
2824
</html>

dev-packages/e2e-tests/test-applications/ember-classic/app/instance-initializers/sentry-performance.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
import type ApplicationInstance from '@ember/application/instance';
2-
import { setupPerformance } from '@sentry/ember';
2+
import { addIntegration, browserTracingIntegration } from '@sentry/ember';
33

44
export function initialize(appInstance: ApplicationInstance): void {
5-
setupPerformance(appInstance, {
5+
addIntegration(browserTracingIntegration({
6+
appInstance,
67
minimumRunloopQueueDuration: 0,
78
minimumComponentRenderDuration: 0,
8-
});
9+
}));
910
}
1011

1112
export default {

dev-packages/e2e-tests/test-applications/ember-embroider/app/app.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,6 @@ Sentry.init({
99
tracesSampleRate: 1,
1010
replaysSessionSampleRate: 1,
1111
replaysOnErrorSampleRate: 1,
12-
browserTracingOptions: {
13-
_experiments: {
14-
// Long-task spans are noisy in e2e and make assertions flaky.
15-
enableLongTask: false,
16-
},
17-
},
1812
tracePropagationTargets: ['localhost', 'doesntexist.example'],
1913
tunnel: `http://localhost:3031/`, // proxy server
2014
});

dev-packages/e2e-tests/test-applications/ember-embroider/app/index.html

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
<meta name="description" content="" />
77
<meta name="viewport" content="width=device-width, initial-scale=1" />
88

9-
<script>if(window.performance&&window.performance.mark){window.performance.mark('@sentry/ember:initial-load-start');}</script>
10-
119
{{content-for "head"}}
1210

1311
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css" />
@@ -21,8 +19,6 @@
2119
<script src="{{rootURL}}assets/vendor.js"></script>
2220
<script src="{{rootURL}}assets/ember-embroider.js"></script>
2321

24-
<script>if(window.performance&&window.performance.mark){window.performance.mark('@sentry/ember:initial-load-end');}</script>
25-
2622
{{content-for "body-footer"}}
2723
</body>
2824
</html>

dev-packages/e2e-tests/test-applications/ember-embroider/app/instance-initializers/sentry-performance.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
import type ApplicationInstance from '@ember/application/instance';
2-
import { setupPerformance } from '@sentry/ember';
2+
import { addIntegration, browserTracingIntegration } from '@sentry/ember';
33

44
export function initialize(appInstance: ApplicationInstance): void {
5-
setupPerformance(appInstance, {
5+
addIntegration(browserTracingIntegration({
6+
appInstance,
67
minimumRunloopQueueDuration: 0,
78
minimumComponentRenderDuration: 0,
8-
});
9+
}));
910
}
1011

1112
export default {
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
/**
3+
Ember CLI sends analytics information by default. The data is completely
4+
anonymous, but there are times when you might want to disable this behavior.
5+
6+
Setting `disableAnalytics` to true will prevent any data from being sent.
7+
*/
8+
"disableAnalytics": true,
9+
}
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# This file is committed to git and should not contain any secrets.
2+
NODE_ENV=development
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# dependencies
2+
/node_modules/
3+
4+
# build output
5+
/dist/
6+
7+
# misc
8+
/.env*
9+
!/.env.development
10+
11+
# test results
12+
/results.junit.xml
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
export default {
2+
extends: "recommended",
3+
checkHbsTemplateLiterals: false,
4+
};

0 commit comments

Comments
 (0)