Skip to content

Commit 5d325df

Browse files
committed
fixup! feat(cloudflare): Add trace propagation for RPC method calls
1 parent f76e06c commit 5d325df

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

packages/cloudflare/src/durableobject.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,10 @@ export function instrumentDurableObjectWithSentry<
146146

147147
return new Proxy(obj, {
148148
get(proxyTarget, prop, receiver) {
149+
const value = Reflect.get(proxyTarget, prop, receiver);
150+
149151
if (typeof prop !== 'string' || BUILT_IN_DO_METHODS.has(prop)) {
150-
return Reflect.get(proxyTarget, prop, receiver);
152+
return value
151153
}
152154

153155
const cached = rpcMethodCache.get(prop);
@@ -156,8 +158,6 @@ export function instrumentDurableObjectWithSentry<
156158
return cached;
157159
}
158160

159-
const value = Reflect.get(proxyTarget, prop, receiver);
160-
161161
if (
162162
typeof value !== 'function' ||
163163
Object.prototype.hasOwnProperty.call(proxyTarget, prop) ||

packages/cloudflare/src/utils/rpcMeta.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ import { getTraceData, type SerializedTraceData } from '@sentry/core';
55
* This enables transparent trace propagation across Cloudflare Workers RPC
66
* calls (Cap'n Proto), which have no native header/metadata support.
77
*/
8-
const SENTRY_RPC_META_KEY = '__sentry';
8+
const SENTRY_RPC_META_KEY = '__sentry_rpc_meta__';
99

1010
interface SentryRpcMeta {
11-
__sentry: SerializedTraceData;
11+
__sentry_rpc_meta__: SerializedTraceData;
1212
}
1313

1414
function isSentryRpcMeta(value: unknown): value is SentryRpcMeta {
1515
if (typeof value !== 'object' || value === null || !(SENTRY_RPC_META_KEY in value)) {
1616
return false;
1717
}
18-
const sentry = (value as SentryRpcMeta).__sentry;
18+
const sentry = (value as SentryRpcMeta).__sentry_rpc_meta__;
1919
return typeof sentry === 'object' && sentry !== null;
2020
}
2121

@@ -51,7 +51,7 @@ export function extractRpcMeta<T extends unknown[]>(
5151
if (isSentryRpcMeta(last)) {
5252
return {
5353
args: args.slice(0, -1) as T,
54-
rpcMeta: last.__sentry,
54+
rpcMeta: last.__sentry_rpc_meta__,
5555
};
5656
}
5757

0 commit comments

Comments
 (0)