Skip to content

Commit 0bc749e

Browse files
committed
use different helper
1 parent eb71e9e commit 0bc749e

5 files changed

Lines changed: 15 additions & 10 deletions

File tree

  • dev-packages/browser-integration-tests/suites/integrations/httpclient

dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/withDataCollection/test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22
import type { Event } from '@sentry/core';
33
import { sentryTest } from '../../../../../utils/fixtures';
4-
import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
4+
import { envelopeRequestParser, waitForErrorRequest } from '../../../../../utils/helpers';
55

66
sentryTest(
77
'should capture request and response headers when using dataCollection options',
@@ -22,7 +22,8 @@ sentryTest(
2222
});
2323
});
2424

25-
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
25+
const req = await Promise.all([waitForErrorRequest(page), page.goto(url)]).then(([r]) => r);
26+
const eventData = envelopeRequestParser<Event>(req);
2627

2728
expect(eventData.exception?.values).toHaveLength(1);
2829

dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/withDisabledDataCollection/test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22
import type { Event } from '@sentry/core';
33
import { sentryTest } from '../../../../../utils/fixtures';
4-
import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
4+
import { envelopeRequestParser, waitForErrorRequest } from '../../../../../utils/helpers';
55

66
sentryTest(
77
'should not capture headers or cookies when dataCollection disables them',
@@ -22,7 +22,8 @@ sentryTest(
2222
});
2323
});
2424

25-
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
25+
const req = await Promise.all([waitForErrorRequest(page), page.goto(url)]).then(([r]) => r);
26+
const eventData = envelopeRequestParser<Event>(req);
2627

2728
expect(eventData.exception?.values).toHaveLength(1);
2829
expect(eventData.message).toBe('HTTP Client Error with status code: 500');

dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/withHeadersOnlyDataCollection/test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22
import type { Event } from '@sentry/core';
33
import { sentryTest } from '../../../../../utils/fixtures';
4-
import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
4+
import { envelopeRequestParser, waitForErrorRequest } from '../../../../../utils/helpers';
55

66
sentryTest(
77
'should capture headers but not cookies when cookies are disabled in dataCollection',
@@ -22,7 +22,8 @@ sentryTest(
2222
});
2323
});
2424

25-
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
25+
const req = await Promise.all([waitForErrorRequest(page), page.goto(url)]).then(([r]) => r);
26+
const eventData = envelopeRequestParser<Event>(req);
2627

2728
expect(eventData.exception?.values).toHaveLength(1);
2829

dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/withoutSendDefaultPii/test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22
import type { Event } from '@sentry/core';
33
import { sentryTest } from '../../../../../utils/fixtures';
4-
import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
4+
import { envelopeRequestParser, waitForErrorRequest } from '../../../../../utils/helpers';
55

66
sentryTest(
77
'should not capture request/response headers or cookies without sendDefaultPii',
@@ -22,7 +22,8 @@ sentryTest(
2222
});
2323
});
2424

25-
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
25+
const req = await Promise.all([waitForErrorRequest(page), page.goto(url)]).then(([r]) => r);
26+
const eventData = envelopeRequestParser<Event>(req);
2627

2728
expect(eventData.exception?.values).toHaveLength(1);
2829
expect(eventData.message).toBe('HTTP Client Error with status code: 500');

dev-packages/browser-integration-tests/suites/integrations/httpclient/xhr/withDataCollection/test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22
import type { Event } from '@sentry/core';
33
import { sentryTest } from '../../../../../utils/fixtures';
4-
import { getFirstSentryEnvelopeRequest } from '../../../../../utils/helpers';
4+
import { envelopeRequestParser, waitForErrorRequest } from '../../../../../utils/helpers';
55

66
sentryTest(
77
'should capture request and response headers from XHR when using dataCollection options',
@@ -22,7 +22,8 @@ sentryTest(
2222
});
2323
});
2424

25-
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
25+
const req = await Promise.all([waitForErrorRequest(page), page.goto(url)]).then(([r]) => r);
26+
const eventData = envelopeRequestParser<Event>(req);
2627

2728
expect(eventData.exception?.values).toHaveLength(1);
2829

0 commit comments

Comments
 (0)