crossdev: unmask multilib when multiple ABIs requested#44
Closed
mattst88 wants to merge 1 commit into
Closed
Conversation
c439961 converted the old set_use_force/set_use_mask calls to the new mask/force pattern, but changed the *) default from removing multilib from the force list to actively masking it. These are not equivalent: the old code allowed multilib to be set via USE when multiple ABIs were requested; the new code prevented it unconditionally. Fix by checking MULTILIB_USE and only masking when it is "no". Fixes: c439961 ("crossdev: use package.use.{mask,force} for pie/ssp")
Member
|
Ouch, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c439961 converted the old set_use_force/set_use_mask calls to the new mask/force pattern, but changed the *) default from removing multilib from the force list to actively masking it. These are not equivalent: the old code allowed multilib to be set via USE when multiple ABIs were requested; the new code prevented it unconditionally.
Fix by checking MULTILIB_USE and only masking when it is "no".
Fixes: c439961 ("crossdev: use package.use.{mask,force} for pie/ssp")