Big code reformat

[Stvad]

@fuddl you mentioned potentially running reformat on the whole codebase after #38 is merged. This is to coordinate on the config/which rules should it enforce.

or

Let's not have unnecessary semicolons & other questions of taste 😛

[Stvad]

Also looking at https://github.com/fuddl/wd/pull/47/files#diff-b856ae74af118e6ad2395d1e1cc0fddd4a243bf239dc8c6e7e390db14b2f85b3L20 it seems most of the code is using single ' quote mark, so maybe it's better stick with that, to minimize actual formatting changes?

[fuddl]

Do you agree with the current state of .eslintrc.yml? Let's simply apply that rules?

Also looking at https://github.com/fuddl/wd/pull/47/files#diff-b856ae74af118e6ad2395d1e1cc0fddd4a243bf239dc8c6e7e390db14b2f85b3L20 it seems most of the code is using single ' quote mark, so maybe it's better stick with that, to minimize actual formatting changes?

agreed.

[Stvad]

Do you agree with the current state of .eslintrc.yml? Let's simply apply that rules?

well, I mentioned 2 things that I think we should change (assuming changes in the linked file were generated based on that config):

• single quotes vs double quotes (to minimize codebase changes)
• don't enforce semicolons/prefer no semicolons (this one is more of the matter of taste)

need to check it more/maybe try applying it to see how it impacts an existing codebase

[fuddl]

* single quotes vs double quotes (to minimize codebase changes)

I have no strong opinion here. I just think single quotes look better 😅

* don't enforce semicolons/prefer no semicolons (this one is more of the matter of taste)

It'll be hard to train my brain to not add semicolons but I'd accept the challenge 🤓.

[Stvad]

Ok, so let's change those & re-apply it to #47 to see impact on code-base (and if we need to adjust anything else)?