fix(pr_v2): httpx client fd leak in 5 remaining PR endpoints

[frankbria]

Problem

get_pr_status was fixed in PR #580 to use try/finally: await client.close(), but five other endpoints in codeframe/ui/routers/pr_v2.py still allocate an httpx.AsyncClient on every request and never close it:

• list_pull_requests (~line 250)
• get_pull_request (~line 290)
• create_pull_request (~line 333)
• merge_pull_request (~line 380)
• close_pull_request (~line 431)

Under load these will accumulate open sockets/file descriptors.

Fix

Apply the same try/finally: await client.close() pattern to each of the five endpoints. The pattern is already established in get_pr_status.

Notes

• Identified by claude-review on PR fix(pr-status): address review feedback missed before merge (#570 follow-up) #580
• Tracked here per reviewer request before merging that PR

[coderabbitai]

🔗 Related PRs

#284 - feat(api): add GitHub PR integration for pull request management [merged]
#531 - fix: address claude-review feedback on blocker origins (#487) [merged]
#579 - feat(web-ui): PR status panel with live CI checks, review, and merge state [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

✅ Successfully generated implementation plan.

💡 Use @coderabbitai <feedback> to replan

---

🧪 Issue enrichment is currently in open beta.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[coderabbitai]

Coding Plan

Summary

• Apply the proven try/finally resource cleanup pattern from get_pr_status to five other endpoints in the same file
• Move client allocation before the try block so it's available in the finally clause
• Add finally: await client.close() to guarantee the httpx connection is released regardless of success or failure
• No new abstractions or refactoring—strictly matching the existing established pattern

Implementation Steps

Apply Resource Cleanup Pattern to PR Endpoints

Apply the established try/finally client lifecycle pattern from get_pr_status to the five endpoints that currently leak connections. Each endpoint requires the same structural change: move client allocation before the try block and add a finally clause that awaits client.close().

Fix Client Lifecycle in All Five Endpoints

Update each of the five affected endpoints in codeframe/ui/routers/pr_v2.py to properly close the GitHub client on all code paths.

• In list_pull_requests (~line 262): Move client = _get_github_client() before the try block; add finally: await client.close() after the exception handlers
• In get_pull_request (~line 302): Apply the same refactor—client allocation before try, add finally clause for cleanup
• In create_pull_request (~line 345): Restructure to match the get_pr_status pattern with finally ensuring client.close() is always called
• In merge_pull_request (~line 392): Move client instantiation outside try block and add the finally: await client.close() clause
• In close_pull_request (~line 443): Apply identical fix—allocate client before try, close in finally

For each endpoint, preserve the existing exception handling logic (GitHubAPIError, HTTPException, generic Exception) unchanged; only the client lifecycle management needs adjustment.

🤖 Prompt for AI agents

Apply the `try/finally` client lifecycle pattern from `get_pr_status` to five
endpoints in `codeframe/ui/routers/pr_v2.py` that currently leak
`httpx.AsyncClient` connections. The goal is to ensure `client.close()` is
always called regardless of success or failure.

For each of the five endpoints below, make the following structural change:
- Move `client = _get_github_client()` to **before** the `try` block
- Add a `finally` clause **after** the existing exception handlers that calls
`await client.close()`
- Do **not** modify any existing exception handling logic (`GitHubAPIError`,
`HTTPException`, generic `Exception`)

Endpoints to update:
- `list_pull_requests` (~line 262)
- `get_pull_request` (~line 302)
- `create_pull_request` (~line 345)
- `merge_pull_request` (~line 392)
- `close_pull_request` (~line 443)

The resulting structure for each endpoint should mirror the pattern already
established in `get_pr_status`.

Research

The PR-related API endpoints live in codeframe/ui/routers/pr_v2.py. All endpoints use a shared factory function _get_github_client() to obtain a GitHubIntegration client instance that wraps an httpx.AsyncClient. The get_pr_status endpoint demonstrates the correct resource management pattern: allocating the client before the try block and closing it in a finally clause. The five broken endpoints allocate the client inside the try block without any finally clause, preventing proper cleanup on exceptions.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Apply the `try/finally` client lifecycle pattern from `get_pr_status` to five
endpoints in `codeframe/ui/routers/pr_v2.py` that currently leak
`httpx.AsyncClient` connections. The goal is to ensure `client.close()` is
always called regardless of success or failure.

For each of the five endpoints below, make the following structural change:
- Move `client = _get_github_client()` to **before** the `try` block
- Add a `finally` clause **after** the existing exception handlers that calls
`await client.close()`
- Do **not** modify any existing exception handling logic (`GitHubAPIError`,
`HTTPException`, generic `Exception`)

Endpoints to update:
- `list_pull_requests` (~line 262)
- `get_pull_request` (~line 302)
- `create_pull_request` (~line 345)
- `merge_pull_request` (~line 392)
- `close_pull_request` (~line 443)

The resulting structure for each endpoint should mirror the pattern already
established in `get_pr_status`.

💡 Iterate on the plan with: @coderabbitai <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!