fix: make CORE_URL_ENV optional

Author: fstr

tests/integration/conftest.py

@@ -27,11 +27,13 @@
 ENGINE_URL_ENV = "ENGINE_URL"
 STOPPED_ENGINE_URL_ENV = "STOPPED_ENGINE_URL"
 CORE_URL_ENV = "CORE_URL"
+
+# Variables to configure the Firebolt Core Helm installation
 CORE_HELM_CHART_VERSION_ENV = "CORE_HELM_CHART_VERSION"
 CORE_DEFAULT_HELM_CHART_VERSION = "0.3.0"
 CORE_IMAGE_TAG_ENV = "CORE_IMAGE_TAG"
+CORE_PORT = 3473
 
-FIREBOLT_CORE_PORT = 3473
 KIND_CLUSTER_NAME = "firebolt-python-sdk"
 
 # https://docs.pytest.org/en/latest/example/simple.html#control-skipping-of-tests-according-to-command-line-option
@@ -179,7 +181,7 @@ def stopped_engine_url(kind_app_setup) -> str:
 
 @fixture(scope="function")
 def core_url(kind_app_setup) -> str:
-    return must_env(CORE_URL_ENV)
+    return getenv(CORE_URL_ENV, "")
 
 
 @fixture(scope="function")
@@ -345,7 +347,7 @@ def deploy_app(kind_cluster, helm_values=None):
             "--for=condition=ready",
             "pod",
             "-l",
-            "app.kubernetes.io/instance=" + release,  # Adjust label to match your chart
+            "app.kubernetes.io/instance=" + release,
             "--namespace",
             ns,
             "--timeout=120s",
@@ -355,7 +357,6 @@ def deploy_app(kind_cluster, helm_values=None):
         check=True,
     )
 
-    # Get pod names
     pod_names_result = subprocess.run(
         [
             "kubectl",
@@ -382,17 +383,15 @@ def deploy_app(kind_cluster, helm_values=None):
         ip = "127.0.0.1"
         port = local_port + i
         ips_with_ports.append(f"{ip}:{port}")
-        print(
-            f"[Kind] Port-forward to pod {pod_name} on {ip}:{port}->{FIREBOLT_CORE_PORT}..."
-        )
+        print(f"[Kind] Port-forward to pod {pod_name} on {ip}:{port}->{CORE_PORT}...")
         pf_proc = subprocess.Popen(
             [
                 "kubectl",
                 "port-forward",
                 "--address",
                 ip,
                 f"pod/{pod_name}",
-                f"{port}:{FIREBOLT_CORE_PORT}",
+                f"{port}:{CORE_PORT}",
                 "-n",
                 ns,
                 "--context",
@@ -401,7 +400,6 @@ def deploy_app(kind_cluster, helm_values=None):
         )
         pf_procs.append(pf_proc)
 
-    sleep(1)
     # Wait for port-forward
     for i in range(10):
         try: