Skip to content

CSS #24

@jema28

Description

@jema28
  1. I like the separation of the pending and completed todos - nice!
  2. It's better to use classes in CSS, I would change these ids to classes and leave ids for javascript.

    toDoApp/style.css

    Lines 66 to 78 in 3766fb0

    #todo {
    width: 300px;
    height: 50px;
    padding-left: 10px;
    }
    #add {
    width: 100px;
    height: 56px;
    font-size: 25px;
    border-radius: 5px;
    float: none;
    /* margin-right: 55%; */
    }
  3. Please avoid using !important - it can cause problems.
    color: #fff !important;
  4. Is there a way you can do this without using floats

    toDoApp/style.css

    Lines 96 to 99 in 3766fb0

    .markTodocontainer {
    float: right;
    background-color: #b1cbbb;
    }

    float: right;
  5. Please delete commented code. This should be seen when other team members are reviewing and merging pull requests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions