fbjs assumes in various places yarn is installed but doesn't declare it as a dependency or call it out in the README. To name a few:
- Build scripts -
|
"fbjs:build": "cd packages/fbjs && yarn && yarn run build", |
|
"fbjs:test": "cd packages/fbjs && yarn && yarn run test", |
|
"fbjs:flow": "cd packages/fbjs && yarn && yarn run flow", |
|
"preset:test": "cd packages/babel-preset-fbjs && yarn && yarn run test", |
|
"signedsource:test": "cd packages/signedsource && yarn && yarn run test" |
fbjs prepublish script -
|
"prepublish": "yarn run build", |
check-dependencies Gulp plugin -
etc.
I believe it would be useful to call out fbjs depends on Facebook's omakase stack in the README at a minimum.
fbjsassumes in various placesyarnis installed but doesn't declare it as a dependency or call it out in the README. To name a few:fbjs/package.json
Lines 18 to 22 in af9fefa
fbjsprepublish script -fbjs/packages/fbjs/package.json
Line 11 in af9fefa
check-dependenciesGulp plugin -fbjs/packages/fbjs-scripts/gulp/check-dependencies.js
Line 25 in ccad8f1
etc.
I believe it would be useful to call out
fbjsdepends on Facebook's omakase stack in the README at a minimum.