Skip to content

Commit c34cc47

Browse files
authored
Merge pull request #739 from extcode/704-undefined-array-key-itemsperpage
[BUGFIX] Check for configuration itemsPerPage in Backend Controller
2 parents 4a69ff7 + 1ce0906 commit c34cc47

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

Classes/Controller/Backend/Order/OrderController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public function listAction(int $currentPage = 1): ResponseInterface
6969
$this->moduleTemplate->assign('settings', $this->settings);
7070
$this->moduleTemplate->assign('searchArguments', $this->searchArguments);
7171

72-
$itemsPerPage = (int)($this->settings['itemsPerPage'] ?? 20);
72+
$itemsPerPage = (isset($this->settings['itemsPerPage']) && is_numeric($this->settings['itemsPerPage'])) ? (int)$this->settings['itemsPerPage'] : 20;
7373

7474
$orderItems = $this->itemRepository->findAll($this->searchArguments);
7575
$arrayPaginator = new QueryResultPaginator(

Classes/Controller/Order/OrderController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function listAction(int $currentPage = 1): ResponseInterface
4949
$feUserUid = $this->context->getPropertyFromAspect('frontend.user', 'id');
5050
$orderItems = $this->itemRepository->findBy(['feUser' => $feUserUid]);
5151

52-
$itemsPerPage = is_numeric($this->settings['itemsPerPage']) ? (int)$this->settings['itemsPerPage'] : 20;
52+
$itemsPerPage = (isset($this->settings['itemsPerPage']) && is_numeric($this->settings['itemsPerPage'])) ? (int)$this->settings['itemsPerPage'] : 20;
5353

5454
$arrayPaginator = new QueryResultPaginator(
5555
$orderItems,

0 commit comments

Comments
 (0)