From b0a231c1433eaf13ee53d3ade589637812d7684c Mon Sep 17 00:00:00 2001 From: erseco Date: Sat, 9 May 2026 13:53:34 +0100 Subject: [PATCH] fix: stop shipping dev artefacts in make package ZIP (#50) `.claude`, `.omc`, `.editor-version`, `.env.dist` and the stray Windows `NUL` file were being picked up by `make package` because they were not listed in `.distignore`. Add them so they no longer end up in release ZIPs. Also document a `Twin-plugin checks` workflow in `AGENTS.md` requiring cross-checks against the sibling `mod_exescorm` repository whenever a fix is applied here. --- .distignore | 5 +++++ AGENTS.md | 12 ++++++++++++ 2 files changed, 17 insertions(+) diff --git a/.distignore b/.distignore index 5ac6818..3d2a2e5 100644 --- a/.distignore +++ b/.distignore @@ -2,9 +2,13 @@ .github .gitignore .aider* +.claude .DS_Store .distignore +.editor-version .env +.env.dist +.omc exelearning/ vendor/ node_modules/ @@ -19,4 +23,5 @@ composer.phar CLAUDE.md AGENTS.md scripts/ +NUL mod_exeweb-*.zip diff --git a/AGENTS.md b/AGENTS.md index b4d64e0..681b676 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -119,3 +119,15 @@ Uses Moodle's file API — packages stored in `mod_exeweb/package` filearea, exp - `make package RELEASE=X.Y.Z` updates `version.php`, creates ZIP excluding files in `.distignore`, then restores dev values - GitHub Actions `release.yml` triggers on git tags: fetches editor, builds, packages, uploads to GitHub Release - `check-editor-releases.yml` runs daily to auto-release when new editor versions appear + +## Twin-plugin checks (mod_exeweb ↔ mod_exescorm) + +`mod_exeweb` and [`mod_exescorm`](https://github.com/exelearning/mod_exescorm) share large amounts of code, history, and bug surface (embedded editor, action bar, packaging pipeline, online callbacks, etc.). **Before closing a fix, always cross-check the sibling plugin:** + +1. **Search the sibling repo for a matching issue.** Examples: + - `gh issue list --repo exelearning/mod_exescorm --search ""` + - `gh issue list --repo exelearning/mod_exescorm --state all --search ""` (also closed) + If a matching issue exists, plan to fix both at once and link them in the PR bodies. +2. **Even if no twin issue is open**, audit the sibling for the same root cause: most bugs reproduce on both sides because the relevant code is intentionally near-identical. +3. When the bug applies to both, **open a PR in each repo** with the parallel fix and **cross-reference the sibling PR** in the body (e.g. `Sibling PR: exelearning/mod_exescorm#65`). Use parallel branch names and commit messages so the diffs are easy to compare. +4. If after auditing only one plugin is affected, document why in the PR body so a future reader doesn't repeat the search.