bitcoin Dockerfile broken since version 29.0

[cozybear-dev]

Hi,

I'm trying to fix it locally, but have not yet figured it out - will create a PR if I manage to do so.

The issue is that from v29.0 and above, the build process for bitcoin has changed. This means that starting from that version, the Dockerfile does not work anymore.

The updated instructions diff (this is for v30, but same goes for v29);

https://github.com/bitcoin/bitcoin/blob/28.x/doc/build-unix.md
https://github.com/bitcoin/bitcoin/blob/30.x/doc/build-unix.md

The primary commit that has introduced this change; bitcoin/bitcoin@6ce50fd#diff-22ee5879377f0f3189b2582508c9c95ac47e4cf33696fc6a6bb4cc8eaac7e9ca

[cozybear-dev]

Managed to distill into this that works;

• I'm unsure regarding the build arguments, I didn't dive into it compared to the current config
• I install the dependencies as packages, instead of compiling myself as that was easier for testing
• this will only work for v29 and above - lower versions will fail with this Dockerfile

FROM debian:stable-slim AS build
ARG BITCOIN_VERSION
RUN apt-get update \
  && apt-get install make patch cmake gnupg2 build-essential curl git pkg-config libevent-dev libboost-dev -y \
  && cd /tmp \
  && curl \
    -O https://raw.githubusercontent.com/bitcoin-core/guix.sigs/main/builder-keys/achow101.gpg \
    -O https://raw.githubusercontent.com/bitcoin-core/guix.sigs/main/builder-keys/fanquake.gpg \
    -O https://raw.githubusercontent.com/bitcoin-core/guix.sigs/main/builder-keys/glozow.gpg \
    -O https://raw.githubusercontent.com/bitcoin-core/guix.sigs/main/builder-keys/guggero.gpg \
    -O https://raw.githubusercontent.com/bitcoin-core/guix.sigs/main/builder-keys/hebasto.gpg \
    -O https://raw.githubusercontent.com/bitcoin-core/guix.sigs/main/builder-keys/theStack.gpg \
    -O https://raw.githubusercontent.com/bitcoin-core/guix.sigs/main/builder-keys/vertiond.gpg \
    -O https://raw.githubusercontent.com/bitcoin-core/guix.sigs/main/builder-keys/willyko.gpg \
  && gpg --import *.gpg \
  && git clone -b v${BITCOIN_VERSION} https://github.com/bitcoin/bitcoin.git \
  && cd bitcoin \
  && git verify-tag v${BITCOIN_VERSION} \
  && cmake -B build -DENABLE_WALLET=OFF -DENABLE_IPC=OFF \
  && cmake --build build \
  && gzexe build/bin/bitcoind \
  && apt-get remove make patch cmake gnupg2 build-essential curl git pkg-config libevent-dev libboost-dev -y


FROM debian:stable-slim
ARG BITCOIN_USER_ID
ARG GROUP_ID
COPY --from=build /tmp/bitcoin/build/bin/bitcoind /usr/local/bin/bitcoind
RUN apt-get update && \
    apt-get install -y --no-install-recommends adduser libevent-dev libboost-dev && \
    rm -rf /var/lib/apt/lists/* \
  && addgroup --gid ${GROUP_ID} bitcoin \
  && adduser -u ${BITCOIN_USER_ID} --disabled-password --gecos "" --ingroup bitcoin bitcoin \
  && mkdir /home/bitcoin/.bitcoin \
  && chown bitcoin:bitcoin /home/bitcoin/.bitcoin

USER bitcoin

CMD bitcoind