Skip to content

Commit 1f12ae4

Browse files
committed
version 0.0.5-rc1
1 parent 1e156ba commit 1f12ae4

File tree

4 files changed

+10
-20
lines changed

4 files changed

+10
-20
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,15 @@
1414
- add 'ShellManager', 'ShellInstance'.
1515
- update 'README.md'
1616

17+
<br />
18+
1719
## 0.0.5
1820
- add Exceptions.
1921
- add 'README.md' to nuget package.
2022
- add github url to nuget package.
23+
24+
<br />
25+
26+
## 0.0.5-rc1
27+
- Fix missing default parameters of 'RunString'.
28+
- Delete unnecessary codes.

Source/PythonShell.NET.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
<PropertyGroup>
1414
<PackageId>PythonShell.NET</PackageId>
15-
<Version>0.0.5</Version>
15+
<Version>0.0.5-rc1</Version>
1616
<Authors>eseunghwan</Authors>
1717
<Company>Integrated.Design.Division</Company>
1818

Source/src/PythonShell.cs

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,13 @@
44
using System.Threading.Tasks;
55
using System.Linq;
66
using System.IO.Compression;
7-
using System.Diagnostics;
8-
using System.Collections.Generic;
97
using System.Runtime.InteropServices;
108

119

1210
namespace PythonShell {
1311
public class PythonShellConfig {
1412
public String DefaultPythonPath { get; set; } = "python3";
1513
public String DefaultPythonVersion { get; set; } = "3.9.13";
16-
// public String? DefaultWorkingDirectory { get; set; } = null;
17-
// public String? PythonRequireFile { get; set; } = null;
18-
// public String[]? PythonRequires { get; set; } = null;
19-
20-
// internal String? AppDir { get; set; } = null;
21-
// internal String TempDir {
22-
// get => Path.Join(AppDir, "temp");
23-
// }
24-
// internal String InstanceDir {
25-
// get => Path.Join(AppDir, "instances");
26-
// }
27-
// internal String? DefaultPythonEnvPath { get; set; } = null;
2814

2915
public PythonShellConfig() {
3016
if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux) || RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) {
@@ -35,10 +21,6 @@ public PythonShellConfig() {
3521
this.DefaultPythonPath = "/usr/bin/python3";
3622
}
3723
}
38-
39-
// if (this.DefaultWorkingDirectory != null) {
40-
// this.DefaultWorkingDirectory = Path.GetFullPath(this.DefaultWorkingDirectory);
41-
// }
4224
}
4325
}
4426

Source/src/Shell/Instance.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public async Task RunFile(String pythonFile, String? workingDirectory = null, Li
6060
await process.WaitForExitAsync();
6161
}
6262

63-
public async Task RunString(String pythonCode, String? workingDirectory, Listener.ShellListener? listener, Boolean echo = true) {
63+
public async Task RunString(String pythonCode, String? workingDirectory = null, Listener.ShellListener? listener = null, Boolean echo = true) {
6464
Listener.ShellListener newListener = listener ?? new Listener.ShellListener();
6565

6666
String tempPythonFile = Path.Join(this.TempDir, $"{DateTime.Now.ToString("yyyy.MM.dd.HH.mm.ss")}.py");

0 commit comments

Comments
 (0)