Prevent graph rearranging on node or

Author: ericceg

README.md

@@ -27,6 +27,7 @@ Core loop:
 - Agent tooling to inspect errors, traverse graph context, read source, and output correction prompts (`python/agents/*`)
 - Live, non-blocking agent run indicators in the desktop UI (phase updates + progress bars while fix suggestions are generated, then auto-hidden when the run ends)
 - Three-column desktop workspace layout: errors (left), graph (center, primary), and a suggestion panel (right) that appears only after an agent workflow run starts
+- Graph force-layout simulation is intentionally reheated only on initial analyze and `Reset view`; selecting nodes or left-panel errors preserves the current arrangement
 - Error list cards emphasize severity, message, and entity label; internal rule codes are hidden from the left-panel card headers
 - Suggestion lifecycle management across agent runs with a single active suggestion panel: close hides the panel, and per-error `Open Suggestion` actions re-open the latest generated suggestion without re-running the agent
 - Settings page with a persisted dark mode toggle for the desktop UI

src/frontend/components/GraphView.tsx

@@ -141,14 +141,6 @@ function GraphView({ graph, focusRequest, selectedNodeId, onNodeClick }: GraphVi
 
   const graphData = useMemo(() => {
     const allNodesById = new Map(graph.nodes.map((node) => [node.id, node]));
-    const keepNodeIds = new Set<string>();
-
-    if (selectedNodeId) {
-      keepNodeIds.add(selectedNodeId);
-    }
-    if (focusRequest?.nodeId) {
-      keepNodeIds.add(focusRequest.nodeId);
-    }
 
     const typeVisibleNodeIds = new Set(
       graph.nodes
@@ -203,7 +195,7 @@ function GraphView({ graph, focusRequest, selectedNodeId, onNodeClick }: GraphVi
       const shouldKeepForIsolation = !hideIsolatedNodes || degree > 0 || node.type === "Error";
       const shouldKeepForDegree = degree >= minVisibleDegree || node.type === "Error";
 
-      if (keepNodeIds.has(nodeId) || (shouldKeepForIsolation && shouldKeepForDegree)) {
+      if (shouldKeepForIsolation && shouldKeepForDegree) {
         visibleNodeIds.add(nodeId);
       }
     }
@@ -233,11 +225,9 @@ function GraphView({ graph, focusRequest, selectedNodeId, onNodeClick }: GraphVi
 
     return { nodes, links };
   }, [
-    focusRequest?.nodeId,
     graph,
     hideIsolatedNodes,
     minVisibleDegree,
-    selectedNodeId,
     showIssueNeighborhoodOnly,
     visibleNodeTypes
   ]);
@@ -277,7 +267,7 @@ function GraphView({ graph, focusRequest, selectedNodeId, onNodeClick }: GraphVi
     [hoveredNodeId, importantNodeIds, labelDensityMode, selectedNodeId, zoomLevel]
   );
 
-  useEffect(() => {
+  const configureGraphForces = useCallback(() => {
     const graphApi = graphRef.current;
     if (!graphApi) {
       return;
@@ -296,10 +286,17 @@ function GraphView({ graph, focusRequest, selectedNodeId, onNodeClick }: GraphVi
         chargeForce.distanceMax(GRAPH_CHARGE_DISTANCE_MAX);
       }
     }
+  }, []);
 
+  useEffect(() => {
+    const graphApi = graphRef.current;
+    if (!graphApi) {
+      return;
+    }
+    configureGraphForces();
     graphApi.d3ReheatSimulation();
     shouldAutoFitRef.current = true;
-  }, [graphData]);
+  }, [configureGraphForces, graph]);
 
   useEffect(() => {
     if (!focusRequest) {
@@ -412,8 +409,13 @@ function GraphView({ graph, focusRequest, selectedNodeId, onNodeClick }: GraphVi
           type="button"
           className="reset-view-button"
           onClick={() => {
-            shouldAutoFitRef.current = false;
-            graphRef.current?.zoomToFit(420, 80);
+            const graphApi = graphRef.current;
+            if (!graphApi) {
+              return;
+            }
+            configureGraphForces();
+            shouldAutoFitRef.current = true;
+            graphApi.d3ReheatSimulation();
           }}
         >
           Reset view