`SuperDropletsMoist` leaks its particle container

[asalmgren]

Location

• Source/Microphysics/SuperDropletsMoist/ERF_SuperDropletsMoist.H:135-136,415
• Source/Microphysics/SuperDropletsMoist/ERF_SuperDropletsMoistInit.cpp:169-175

Problem

SuperDropletsMoist allocates m_super_droplets with new:

m_super_droplets = new SuperDropletPC(...);

but uses a default destructor and never deletes it.

Why this is a bug

This is an ownership/lifetime bug: each model instance leaks one SuperDropletPC and associated allocations. In long-running workflows with reinitialization/restart cycles or repeated object construction, this causes avoidable memory growth.

Suggested patch

Use RAII ownership (std::unique_ptr) for m_super_droplets.

--- a/Source/Microphysics/SuperDropletsMoist/ERF_SuperDropletsMoist.H
+++ b/Source/Microphysics/SuperDropletsMoist/ERF_SuperDropletsMoist.H
@@
-        inline virtual ERFPC* getParticleContainer() override
+        inline virtual ERFPC* getParticleContainer() override
         {
-            return m_super_droplets;
+            return m_super_droplets.get();
         }
@@
-        SuperDropletPC* m_super_droplets;
+        std::unique_ptr<SuperDropletPC> m_super_droplets;

--- a/Source/Microphysics/SuperDropletsMoist/ERF_SuperDropletsMoistInit.cpp
+++ b/Source/Microphysics/SuperDropletsMoist/ERF_SuperDropletsMoistInit.cpp
@@
-    m_super_droplets = new SuperDropletPC ( a_geom,
-                                            a_cons_vars.DistributionMap(),
-                                            a_cons_vars.boxArray(),
-                                            m_species,
-                                            m_aerosols,
-                                            m_dt,
-                                            m_name );
+    m_super_droplets = std::make_unique<SuperDropletPC> ( a_geom,
+                                                           a_cons_vars.DistributionMap(),
+                                                           a_cons_vars.boxArray(),
+                                                           m_species,
+                                                           m_aerosols,
+                                                           m_dt,
+                                                           m_name );

[debog]

Not a leak: SuperDropletsMoist allocates the SuperDropletPC with new, but ownership is transferred to ERF::particleData via pushBack() at ERF.cpp:1189. ParticleData::~ParticleData() calls delete on all stored particle containers during teardown.

Destruction order is safe: particleData is declared after micro in ERF.H (lines 863 vs 1178), so it is destroyed first (reverse declaration order), while all microphysics state is still alive.

Using unique_ptr here causes a double-free (segfault at exit) because both ParticleData and the unique_ptr destructor try to delete the same object.

Added a clarifying ownership comment on the raw pointer declaration in commit 8c7e9f6.