pitboss: sweep system#10
Merged
Merged
Conversation
…pdate references; streamline `sweep_auditor` input parameters for clarity
…ed-sweep steps, update related logic and tests, and ensure proper state management during fresh runs
…atch_through_fixer and run_audit_and_stage for clearer separation of concerns; enhance audit handling and state management during sweeps
…iple files by removing unnecessary line breaks and enhancing function signatures for clarity
…ode::Failure` to `ExitCode::MixedFailures` in the sweep subcommand
There was a problem hiding this comment.
Pull request overview
Adds first-class “deferred sweep” support to Pitboss, enabling automatic/manual backlog-draining passes between phases (and after the final phase), with new CLI controls, status/TUI visibility, prompt templates, and centralized exit code semantics.
Changes:
- Introduces sweep trigger + staleness tracking (per-item attempt counters, stale-item events/caps) and a bounded final-sweep drain loop.
- Adds
pitboss sweepplus--sweep/--no-sweepoverrides forplay/rebuy, and expands prompts/docs to describe sweep behavior and invariants. - Refactors exit codes into a shared
src/cli/exit_code.rsand updates CLI/subsystems to use it consistently.
Reviewed changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/cli/sweep.rs |
New pitboss sweep subcommand wiring a standalone sweep into the runner. |
src/runner/sweep.rs |
Pure sweep trigger helpers + staleness-map update logic (incl. threshold-crossing detection). |
src/config/mod.rs |
Adds [sweep] config block, defaults, validation, and unknown-key detection. |
src/state/mod.rs |
Extends RunState with sweep-related persistence fields and legacy deserialization coverage. |
src/cli/mod.rs |
Adds Sweep command and --sweep/--no-sweep flags to play/rebuy dispatch. |
src/cli/status.rs |
Extends status report with a “Sweep” block and stale-item rendering. |
src/prompts/mod.rs + templates/snapshots |
Adds sweep implementer/auditor/fixer templates, stale-item rendering, and snapshots/tests. |
tests/*sweep*.rs, tests/cli_*.rs |
Broad integration coverage for sweep boundaries, auditor behavior, staleness, final-loop draining, and CLI plumbing. |
src/cli/exit_code.rs + src/grind/budget.rs |
Centralizes exit codes and re-exports for compatibility. |
README.md |
Documents sweep rationale, workflow, overrides, and config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… by synthesizing in-memory state and ensuring branch consistency; update documentation for clarity on state persistence during halts
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 42 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // overlap assertion is the real correctness gate: in a serialized | ||
| // dispatch overlap is zero, so requiring overlap ≥ session_sleep / 2 | ||
| // already rules out the regression the elapsed bound was guarding. | ||
| let _ = elapsed; |
Comment on lines
+125
to
+126
| /// `deferred.md` by hand. See `[sweep]` in `pitboss.toml` for the | ||
| /// thresholds the override bypasses. |
Comment on lines
+178
to
+187
| // Persist state.json only when a real run is in flight. The runner | ||
| // honors `persist_state` on its success path; we mirror that on the | ||
| // halt path so a halted sweep can be retried. When `state_existed` | ||
| // is false the synthesized state was in-memory bookkeeping only and | ||
| // never touches disk. | ||
| if state_existed { | ||
| if let Err(e) = state::save(&workspace, Some(runner.state())) { | ||
| eprintln!("[pitboss] failed to persist state.json after sweep: {e:#}"); | ||
| } | ||
| } |
…d sweeps and enhance error handling for state saving; ensure proper cleanup of resources after execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major new feature to the Pitboss CLI: deferred-item sweeps, which allow the system to automatically or manually address lingering items in the deferred backlog between plan phases. It also adds new CLI flags for sweep control, documents the sweep process in detail, and refactors exit code handling for consistency across subcommands. The changes update both the codebase and documentation to support and explain these new capabilities.
Key changes:
1. Deferred-item sweeps (core feature):
deferred.mdbacklog between plan phases, with configurable thresholds, caps, escalation, and audit integration. Sweeps can also be triggered or suppressed via CLI flags. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]2. CLI enhancements and sweep control:
pitboss sweepsubcommand for one-shot sweeps, and new--sweepand--no-sweepflags topitboss playandpitboss rebuyfor controlling sweep behavior per run. Updates CLI argument parsing and runner logic accordingly. [1] [2] [3] [4] [5] [6] [7]3. Documentation and configuration:
README.mdwith a comprehensive section on sweeps, including rationale, workflow, configuration options, and manual override instructions. Documents new[sweep]config block in example configs. [1] [2] [3] [4]4. Exit code refactor:
src/cli/exit_code.rsmodule, ensuring consistent semantics and numeric values across all subcommands (including sweep). Updates usage throughout CLI dispatch. [1] [2] [3] [4]5. Miscellaneous improvements:
strumdependency for enum utilities. Updates status reporting to include sweep-related information and stale item display cap. [1] [2] [3]These changes collectively make deferred backlog management a first-class, configurable, and well-documented part of the Pitboss workflow, improving both automation and operator control.