fix(gist): change label to secret (not private) (#1812)

* fix(gist): secret (not private)

* test name too

Author: erickzhao

rtl-spec/components/commands-publish-button.spec.tsx

@@ -242,9 +242,9 @@ describe('Action button component', () => {
       expect(state.editorMosaic.isEdited).toBe(true);
     });
 
-    it('can publish private gists', async () => {
+    it('can publish secret gists', async () => {
       state.showInputDialog = vi.fn().mockResolvedValueOnce(description);
-      instance.setPrivate();
+      instance.setSecret();
       await instance.performGistAction();
       const { create } = mocktokit.gists;
       expect(create).toHaveBeenCalledWith({
@@ -374,7 +374,7 @@ describe('Action button component', () => {
       instance.setPublic();
       expect(state.gitHubPublishAsPublic).toBe(true);
 
-      instance.setPrivate();
+      instance.setSecret();
       expect(state.gitHubPublishAsPublic).toBe(false);
     });
   });

src/renderer/components/commands-action-button.tsx

@@ -46,7 +46,7 @@ export const GistActionButton = observer(
       super(props);
       this.handleClick = this.handleClick.bind(this);
       this.performGistAction = this.performGistAction.bind(this);
-      this.setPrivate = this.setPrivate.bind(this);
+      this.setSecret = this.setSecret.bind(this);
       this.setPublic = this.setPublic.bind(this);
 
       this.state = {
@@ -298,9 +298,9 @@ export const GistActionButton = observer(
     }
 
     /**
-     * Publish fiddles as private.
+     * Publish fiddles as secret.
      */
-    public setPrivate() {
+    public setSecret() {
       this.setPrivacy(false);
     }
 
@@ -414,10 +414,10 @@ export const GistActionButton = observer(
       const privacyMenu = (
         <Menu>
           <MenuItem
-            text="Private"
+            text="Secret"
             icon="lock"
             active={!gitHubPublishAsPublic}
-            onClick={this.setPrivate}
+            onClick={this.setSecret}
           />
           <MenuItem
             text="Public"