feat: add CI STEP geometry export test workflow#59
Merged
Conversation
Agent-Logs-Url: https://github.com/eic/npsim/sessions/c0678f12-df55-4bde-a156-5eb7f26367c8 Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Agent-Logs-Url: https://github.com/eic/npsim/sessions/c0678f12-df55-4bde-a156-5eb7f26367c8 Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
wdconinc
May 20, 2026 02:05
View session
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The 'env' context is not available in 'with' inputs of a reusable workflow call. Replace env.platform, env.release, and env.organization with inline expressions using the 'inputs' context with hardcoded defaults, which is the same fallback logic used in the env section. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wdconinc
reviewed
May 20, 2026
Capybara summary for PR 59
|
wdconinc
reviewed
May 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable GitHub Actions workflow to export EPIC detector geometries to STEP via npdet_to_step, and wires it into the existing linux-eic-shell CI pipeline to validate generated .stp outputs.
Changes:
- Introduces reusable workflow
.github/workflows/convert-to-step.ymlto export STEP files and assert they’re non-empty. - Adds a new
convert-to-stepjob in.github/workflows/linux-eic-shell.ymlthat calls the reusable workflow after the build job. - Sets explicit
permissionsin the reusable workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .github/workflows/linux-eic-shell.yml | Adds a post-build job that calls the reusable STEP-export workflow with a detector-config matrix. |
| .github/workflows/convert-to-step.yml | New reusable workflow that downloads the install artifact, runs npdet_to_step in eic-shell, validates output, and uploads .stp artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
wdconinc
reviewed
May 20, 2026
wdconinc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/convert-to-step.ymlworkflow that exports STEP geometry withnpdet_to_step/opt/detector/epic-mainand validate generated.stpfiles are non-emptylinux-eic-shell.ymlto call the new workflow for a set of standard geometries after the build jobpermissionsin the reusable workflowValidation
cmake -S . -B /tmp/npsim-precheck-build && cmake --build ... && ctest ...(fails early due missingDD4hepConfig.cmakein this environment)codeql_checkerfor GitHub Actions and resolved the reported permissions alert; re-run reports 0 alerts