Use CMake option() for USE_GEOCAD#54
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/eic/npsim/sessions/d7bdb98f-cf21-46af-9a45-881bb10dddb2 Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
wdconinc
May 17, 2026 18:29
View session
wdconinc
approved these changes
May 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces a cache variable declaration with the idiomatic CMake option() call for USE_GEOCAD, preserving the default value (ON) and description.
Changes:
- Switch
set(USE_GEOCAD ON CACHE BOOL ...)tooption(USE_GEOCAD ... ON)in the top-level CMakeLists.txt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Capybara summary for PR 54
|
Contributor
|
Likely will conflict with #50 after merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the top-level
USE_GEOCADcache variable declaration with an explicit CMakeoption()call.Changes
/home/runner/work/npsim/npsim/CMakeLists.txt:set(USE_GEOCAD ON CACHE BOOL ...)→option(USE_GEOCAD ... ON)Validation
cmake -S . -B buildbefore and after change.DD4hepConfig.cmake(pre-existing environment dependency), unchanged by this patch.