Skip to content

Commit 17864c0

Browse files
committed
Fix Faker::Internet.safe_email compatibility issue
1 parent 44885de commit 17864c0

2 files changed

Lines changed: 3 additions & 11 deletions

File tree

.github/workflows/test.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,4 @@ jobs:
7878
7979
- name: Run RSpec tests
8080
run: |
81-
DB_ADAPTER=postgresql bundle exec rspec --format progress
82-
83-
- name: Upload coverage to Coveralls
84-
if: github.event_name == 'push'
85-
uses: coverallsapp/github-action@v2
86-
with:
87-
github-token: ${{ secrets.GITHUB_TOKEN }}
88-
path-to-lcov: ./coverage/lcov/otb-api-server.lcov
89-
continue-on-error: true
81+
DB_ADAPTER=postgresql bundle exec rspec --format progress

spec/controllers/v3/users_controller_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595

9696
describe 'POST #create' do
9797
let(:user) { create(:user, super: false) }
98-
let(:valid_params) { { data: { type: 'users', attributes: { display_name: Faker::Music::Hiphop.artist, email: Faker::Internet.safe_email } }, tenant: 'public' } }
98+
let(:valid_params) { { data: { type: 'users', attributes: { display_name: Faker::Music::Hiphop.artist, email: Faker::Internet.email } }, tenant: 'public' } }
9999

100100
context 'unauthorized' do
101101
it 'does not create a new User when unauthenticated' do
@@ -276,4 +276,4 @@
276276
end
277277
end
278278
end
279-
end
279+
end

0 commit comments

Comments
 (0)