real fork or not

[duck7000]

@ALL
@GeorgeFive
I am thinking about this question for a long time and want to know what your, the users, view is on this question?
There was a user at imdbphp that i offered to use my version but he couldn't use it because differences (mainly in PSR version) so that got me thinking about this.

At the time i decided that my library would not be a fork and that it would become a very stripped version of the original.
This thought changed over time, it did become a full blown version and it is almost a full fork of the original.

So the question is should my project be a one on one fork of imdbphp or not?

There are a few differences:
some method names differ
some method output is different (mostly due to extra functions/data)
additional methods that are not in imdbphp
additional classes that are not in imdbphp

Please share your thoughts about this!

[GeorgeFive]

I like how this one is cleaner and more descriptive with the names, so my vote would be to leave it alone.

With that said, if you want to make it more plug-and-play compatible for their users, maybe we could do "redirect" classes?

What I mean is.... this class has metacritic(). They have metacriticRating() and metacriticNumReviews(), so a user coming from imdbphp will have broken code due to those classes not existing here.

So, we could have a dummy class for each: metacriticRating() will return only score from metacritic(), and metacriticNumReviews() will return only reviewCount from metacritic(). If you want your imdbphp-dependent code to "just work" with no changes, it will. However, if you want the full functionality of metacritic(), you need to do some work on your own code.

Could even make it an optional include:

Coming from imdbphp? require_once ("imdb6/imdbphp-functions.php");
Otherwise, no need to include that file, carry on as normal.

With this logic, you could even set a flag inside imdbphp-functions.php, say "imdbphp = y".

In the case of differing outputs, example, our country() and their country() have different values....

if imdbphp = y = use country() from imdbphp-functions.php, use Psr-old\Log\LoggerInterface;
else = use country() from main class, use Psr\Log\LoggerInterface;

[duck7000]

@GeorgeFive Thanks for your detailed answer!

I do like it like it is so my vote would also be leave it alone.

But if more imdbphp user would use this library they will hit issues, most leave right away but for the ones that stay i might consider modifications.
I like your idea of a optional require, remove the comment mark and it will act like imdbphp but this require a lot of work.

I'll think about it, no rush