feat: refactor workflow for Jekyll site to streamline build, test, and deploy stages

Author: SabotageAndi

.github/workflows/jekyll.yml

@@ -1,17 +1,15 @@
-# Combined workflow for testing and deploying Jekyll site to GitHub Pages
-# Tests must pass before deployment proceeds
-# Uses devcontainer for consistent environment between local dev and CI
+# Three-stage workflow: Build → Test → Deploy
+# Build: builds Jekyll site and uploads artifact
+# Test: runs Playwright tests, uploads results, never fails the pipeline
+# Deploy: deploys to GitHub Pages (skipped on pull requests)
 
-name: Test and Deploy Jekyll site to Pages
+name: Build, Test and Deploy Jekyll site to Pages
 
 on:
-  # Runs on pushes targeting the default branch
   push:
     branches: ["master"]
   pull_request:
     branches: ["master"]
-
-  # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:
     inputs:
       update_snapshots:
@@ -20,24 +18,19 @@ on:
         default: false
         type: boolean
 
-# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
 permissions:
   contents: read
   pages: write
   id-token: write
 
-# Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued.
-# However, do NOT cancel in-progress runs as we want to allow these production deployments to complete.
 concurrency:
   group: "pages"
   cancel-in-progress: false
 
 jobs:
-  # Build job - uses devcontainer
+  # Stage 1: Build - builds the Jekyll site and uploads the pages artifact
   build:
     runs-on: ubuntu-latest
-    # Only build on push to master (not on PRs)
-    if: github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && !inputs.update_snapshots)
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -56,15 +49,15 @@ jobs:
         env:
           JEKYLL_ENV: production
 
-      - name: Upload artifact
+      - name: Upload pages artifact
         uses: actions/upload-pages-artifact@v3
 
-  # Test job - runs Playwright tests using devcontainer for consistent environment
+  # Stage 2: Test - runs Playwright tests, uploads results, never fails
   test:
-    timeout-minutes: 60
     runs-on: ubuntu-latest
     needs: build
-    if: always() && !cancelled()
+    continue-on-error: true
+    timeout-minutes: 60
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -111,19 +104,19 @@ jobs:
 
       - name: Upload Playwright Report
         uses: actions/upload-artifact@v4
-        if: ${{ !cancelled() }}
+        if: always()
         with:
           name: playwright-report
           path: playwright-report/
-          retention-days: 30
+          retention-days: 7
 
       - name: Upload Test Results
         uses: actions/upload-artifact@v4
-        if: ${{ !cancelled() }}
+        if: always()
         with:
           name: test-results
           path: test-results/
-          retention-days: 30
+          retention-days: 7
 
       - name: Upload Updated Snapshots
         uses: actions/upload-artifact@v4
@@ -133,30 +126,17 @@ jobs:
           path: |
             tests/**/*.png
             tests/**/*.txt
-          retention-days: 30
+          retention-days: 7
 
-  # Deployment job - only runs after build succeeds
+  # Stage 3: Deploy - deploys to GitHub Pages (skipped on pull requests)
   deploy:
-    if: needs.test.result == 'success' && needs.build.result == 'success'
+    runs-on: ubuntu-latest
+    needs: [build, test]
+    if: github.event_name != 'pull_request'
     environment:
       name: github-pages
       url: ${{ steps.deployment.outputs.page_url }}
-    runs-on: ubuntu-latest
-    needs: [test, build]
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
         uses: actions/deploy-pages@v4
-
-  # Deployment job when tests failed - requires manual approval
-  deploy_manual:
-    if: always() && needs.test.result == 'failure' && needs.build.result == 'success'
-    environment:
-      name: github-pages-approval
-      url: ${{ steps.deployment.outputs.page_url }}
-    runs-on: ubuntu-latest
-    needs: [test, build]
-    steps:
-      - name: Deploy to GitHub Pages (manual approval)
-        id: deployment
-        uses: actions/deploy-pages@v4