New api-diff suppressions

[NikolaMilosavljevic]

New api-diff suppressions are showing in internal 10.0.1xx build

sdk/x.y.z/Spectre.Console.dll

  <Suppression>
    <DiagnosticId>CP0001</DiagnosticId>
    <Target>T:System.Runtime.CompilerServices.IsExternalInit</Target>
    <Left>/msft/sdk/x.y.z/Spectre.Console.dll</Left>
    <Right>/sb/sdk/x.y.z/Spectre.Console.dll</Right>
  </Suppression>
  <Suppression>
    <DiagnosticId>CP0001</DiagnosticId>
    <Target>T:System.Runtime.CompilerServices.RequiresLocationAttribute</Target>
    <Left>/msft/sdk/x.y.z/Spectre.Console.dll</Left>
    <Right>/sb/sdk/x.y.z/Spectre.Console.dll</Right>
  </Suppression>
  <Suppression>
    <DiagnosticId>CP0003</DiagnosticId>
    <Target>Spectre.Console, Version=x.y.z, Culture=neutral, PublicKeyToken=170fe27f8af98a30</Target>
    <Left>/msft/sdk/x.y.z/Spectre.Console.dll</Left>
    <Right>/sb/sdk/x.y.z/Spectre.Console.dll</Right>
  </Suppression>

[NikolaMilosavljevic]

Last instance in the list above is above assembly version - it can be ignored.

The other two are for type forwarders - missing in source-build assembly:

.class extern forwarder System.Runtime.CompilerServices.IsExternalInit
{
  .assembly extern System.Runtime
}
.class extern forwarder System.Runtime.CompilerServices.RequiresLocationAttribute
{
  .assembly extern System.Runtime
}

[ellahathaway]

This is now showing in the 2xx branch as well: dotnet/dotnet#3847

[ViktorHofer]

This difference shows up because PolySharp which provides these downlevel types / type fowards is conditioned out for Spectre.Console: https://github.com/dotnet/source-build-reference-packages/blob/cc90bb4ad53ff35dc109c2827428113e70a4681d/src/externalPackages/patches/spectre-console/0001-Remove-PolySharp.patch#L18

Intentional, I guess.

[mthalman]

@NikolaMilosavljevic - Is this still an issue? We should try to get this resolved soon.