-
Notifications
You must be signed in to change notification settings - Fork 387
Description
Background and Motivation
Currently it seems only dotnet-trace and dotnet-counters support the --diagnostic-port parameter. Documentation incorrectly states that diagnostic port is supported as a parameter to dotnet-dump.
This limits tooling to scenarios with shared process namespace and requires us to configure a separate listener such as dotnet-monitor. It would be useful to be able to use diagnostic tooling in scenarios with only shared diagnostic port socket (e.g. shared emptyDir between containers).
Since we can now connect to diagnostic ports using DiagnosticClient is there a reason this capability is not available in all tooling such as dotnet-dump?
Proposed Feature
Add --diagnostic-port support to tooling where it is supported by DiagnosticClient.
Usage Examples
dotnet-dump collect --diagnostic-port /tmp/dotnet-diagnostic-1-23456-socket,connect