[Bug]: Site unusable after upgrade to 10.3.0 due to Login module and DDR Menu not rendering

[lanthonyneville]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

The upgrade to 10.3.0 was applied to a working 10.2.X site (not sure which X). The upgrade completed successfully, but on restart, two issues stop the site being usable.

Steps to reproduce?

1. Apply 10.3.0 upgrade to 10.2.X site that uses DDR Menu in theme

Current Behavior

1. The Login module will not render, and a Page Load Exception is seen in the event log (see details below)
2. (if I make all pages accessible to anonymous through the DB) the DDR Menu will not render, and a Module Load Exception is seen in the event log (see details below)

Note: If I switch to the Aperture skin & container (by updating PortalSettings via DB) issue 1 persists; the nav menu does appear I guess because it doesn't use DDR Menu

Expected Behavior

1. Login module should render
2. DDR Menu should render

Relevant log output

EventType	LogProperties	ExceptionMessage	ExceptionStackTrace
Page Load Exception	<LogProperties><LogProperty><PropertyName>AbsoluteURL</PropertyName><PropertyValue>/Default.aspx</PropertyValue></LogProperty><LogProperty><PropertyName>DefaultDataProvider</PropertyName><PropertyValue>DotNetNuke.Data.SqlDataProvider, DotNetNuke</PropertyValue></LogProperty><LogProperty><PropertyName>ExceptionGUID</PropertyName><PropertyValue>d5203a43-a7a7-4b52-a46a-983d5bcb7696</PropertyValue></LogProperty></LogProperties>	Index was outside the bounds of the array.	at DotNetNuke.UI.WebControls.DNNTab.SaveViewState() at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode) at System.Web.UI.Page.SaveAllState() at System.Web.UI.Page.<ProcessRequestMainAsync>d__523.MoveNext()
Module Load Exception	<LogProperties><LogProperty><PropertyName>ModuleId</PropertyName><PropertyValue>-1</PropertyValue></LogProperty><LogProperty><PropertyName>ModuleDefId</PropertyName><PropertyValue>-1</PropertyValue></LogProperty><LogProperty><PropertyName>FriendlyName</PropertyName><PropertyValue /></LogProperty><LogProperty><PropertyName>ModuleControlSource</PropertyName><PropertyValue /></LogProperty><LogProperty><PropertyName>AbsoluteURL</PropertyName><PropertyValue>/Default.aspx</PropertyValue></LogProperty><LogProperty><PropertyName>DefaultDataProvider</PropertyName><PropertyValue>DotNetNuke.Data.SqlDataProvider, DotNetNuke</PropertyValue></LogProperty><LogProperty><PropertyName>ExceptionGUID</PropertyName><PropertyValue>9b4c40bc-40a6-41c5-9591-04c66d00004a</PropertyValue></LogProperty></LogProperties>	Cannot deserialize type 'DotNetNuke.Entities.Users.UserProfile' because it contains property 'IsDirty' which has no public setter.	at System.Xml.Serialization.TypeScope.GetSettableMembers(StructMapping mapping, ArrayList list) at System.Xml.Serialization.TypeScope.GetSettableMembers(StructMapping structMapping) at System.Xml.Serialization.XmlSerializationReaderILGen.WriteLiteralStructMethod(StructMapping structMapping) at System.Xml.Serialization.XmlSerializationReaderILGen.GenerateMethod(TypeMapping mapping) at System.Xml.Serialization.XmlSerializationILGen.GenerateReferencedMethods() at System.Xml.Serialization.XmlSerializationReaderILGen.GenerateEnd(String[] methods, XmlMapping[] xmlMappings, Type[] types) at System.Xml.Serialization.TempAssembly.GenerateRefEmitAssembly(XmlMapping[] xmlMappings, Type[] types, String defaultNamespace, Evidence evidence) at System.Xml.Serialization.TempAssembly..ctor(XmlMapping[] xmlMappings, Type[] types, String defaultNamespace, String location, Evidence evidence) at System.Xml.Serialization.XmlSerializer.GenerateTempAssembly(XmlMapping xmlMapping, Type type, String defaultNamespace, String location, Evidence evidence) at System.Xml.Serialization.XmlSerializer..ctor(Type type, XmlAttributeOverrides overrides, Type[] extraTypes, XmlRootAttribute root, String defaultNamespace, String location, Evidence evidence) at DotNetNuke.Web.DDRMenu.DNNCommon.Utilities.SerialiserFor(Type t) at DotNetNuke.Web.DDRMenu.TemplateEngine.TokenTemplateProcessor.Render(Object source, HtmlTextWriter htmlWriter, TemplateDefinition liveDefinition) at DotNetNuke.Web.DDRMenu.MenuBase.Render(HtmlTextWriter htmlWriter) at DotNetNuke.Web.DDRMenu.SkinObject.Render(HtmlTextWriter writer)

Affected Versions

10.3.0 (latest release)

What browsers are you seeing the problem on?

All

Code of Conduct

• I agree to follow this project's Code of Conduct

[jeremy-farrance]

To help in debugging this, would you be willing and able to share the DDR Menu XSLT Template file/code? Also, I do believe this same issue (IsDirty, public setter missing) was addressed and will be fixed in 10.03.01. See #7158.

[valadas]

#7160 might have fixed this issue, if you have a non-production copy of that site, can you try to update it to this unreleased version https://github.com/dnnsoftware/Dnn.Platform/actions/runs/23907705426/artifacts/6244760181 to test.

This is not an official release, so don't install that on production yet, it is just to see if it fixes your issue.

[lanthonyneville]

#7160 might have fixed this issue, if you have a non-production copy of that site, can you try to update it to this unreleased version https://github.com/dnnsoftware/Dnn.Platform/actions/runs/23907705426/artifacts/6244760181 to test.

This is not an official release, so don't install that on production yet, it is just to see if it fixes your issue.

Thanks ... I tried installing DNN_Platform_10.3.1-alpha.112_Upgrade.zip over my site, but now get this:

[FileLoadException: Could not load file or assembly 'System.Collections.Immutable, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)]
System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks) +0
System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks) +232
System.Reflection.RuntimeAssembly.InternalLoad(String assemblyString, Evidence assemblySecurity, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean forIntrospection) +113
System.Reflection.RuntimeAssembly.InternalLoad(String assemblyString, Evidence assemblySecurity, StackCrawlMark& stackMark, Boolean forIntrospection) +23
System.Reflection.Assembly.Load(String assemblyString) +35
System.Web.Configuration.CompilationSection.LoadAssemblyHelper(String assemblyName, Boolean starDirective)

[lanthonyneville]

To help in debugging this, would you be willing and able to share the DDR Menu XSLT Template file/code? Also, I do believe this same issue (IsDirty, public setter missing) was addressed and will be fixed in 10.03.01. See #7158.

Thanks, here is my menu.txt:

<ul class="slimmenu normal" id="navigation">
  [*>NODE-TOP]
</ul>

  [>NODE-TOP]
    <li[?SELECTED] class="active"[/?]>
      
      [?ENABLED]
        <a href="[=URL]" class="btn menu-btn[?NODE] split[/?]" target="[=TARGET]">[=TEXT]</a>
      [?ELSE]    
        <a href="#" class="btn menu-btn[?NODE] single[/?]" target="[=TARGET]">[=TEXT]</a>
      [/?]
      
      [?NODE]
        <ul>
          [*>NODE]
        </ul>
      [/?]
    </li>
  [/>]
  
  [>NODE]
    <li class="[?SELECTED] active[/?]">
      
      [?ENABLED]  
        <a href="[=URL]" [?NODE]class="split"[/?] target="[=TARGET]">[=TEXT]</a>
      [?ELSE]
        <a href="#" target="[=TARGET]">[=TEXT]</a>
      [/?]
      
      [?NODE]
        <ul>
          [*>NODE]
        </ul>
      [/?]
    </li>
  [/>]

[jeremy-farrance]

#7160 might have fixed this issue, ...

Thanks ... I tried installing DNN_Platform_10.3.1-alpha.112_Upgrade.zip over my site, but now get this:

[FileLoadException: Could not load file or assembly 'System.Collections.Immutable, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the

That seems to confirm that the fix you need for your DDR XSLT Template is already in the fix from Issue #7158.

Now you have a new issue which is a DLL version mismatch. @bdukes may be interested in this (because I believe it is a newer one that we haven't seen previously?).

Are you familiar with how to resolve those with a BindingRedirect in web.config?

[lanthonyneville]

Are you familiar with how to resolve those with a BindingRedirect in web.config?

There was actually already a redirect for System.Collections.Immutable in the config (see below), but I have been trying different numbers and not got it to work. What is the correct newVersion value? The DLL in the bin details are below.

      <dependentAssembly xmlns="urn:schemas-microsoft-com:asm.v1">
        <assemblyIdentity name="System.Collections.Immutable" publicKeyToken="b03f5f7f11d50a3a" />
        <bindingRedirect oldVersion="0.0.0.0-32767.32767.32767.32767" newVersion="9.0.0.0" />
      </dependentAssembly>

[jeremy-farrance]

I did a new/clean install of DNN v10.03.00 and here is what is in the bindingRedirect - so I assume 9.0.0.2 will get it to work.

      <dependentAssembly xmlns="urn:schemas-microsoft-com:asm.v1">
        <assemblyIdentity name="System.Collections.Immutable" publicKeyToken="b03f5f7f11d50a3a" />
        <bindingRedirect oldVersion="0.0.0.0-32767.32767.32767.32767" newVersion="9.0.0.2" />
      </dependentAssembly>

In your screenshot above the details are showing the File version and the Assembly version. What you need is the Assembly version. At the moment, I don't remember a reliable or easy way to get that from the DLL file. I am sure there is.

[meetmandeep]

Cannot deserialize type 'DotNetNuke.Entities.Users.UserProfile' because it contains property 'IsDirty' which has no public setter.

I can confirm that this is a Show Stopper for Mandeeps.com Themes as well. All of our customers are affected running DNN 10.3.0

[jeremy-farrance]

I can confirm that this is a Show Stopper for Mandeeps.com Themes as well. All of our customers are affected running DNN 10.3.0

Each DNN release has a Release Candidate, sometimes more than one. So it seems like you could have caught this by testing the RC before it became a full release.

[lanthonyneville]

I did a new/clean install of DNN v10.03.00 and here is what is in the bindingRedirect - so I assume 9.0.0.2 will get it to work.

Thanks, using 9.0.0.2 got past that issue. However then the error became: Could not load file or assembly 'System.Text.Encoding.CodePages, Version=9.0.0.2. There was a bindingRedirect in the config pointing to 9.0.0.2 but the System.Text.Encoding.CodePages.dll looks to be version 8.0.0. After setting the redirects to the following the site came up:

      <dependentAssembly xmlns="urn:schemas-microsoft-com:asm.v1">
        <assemblyIdentity name="System.Collections.Immutable" publicKeyToken="b03f5f7f11d50a3a" />
        <bindingRedirect oldVersion="0.0.0.0-32767.32767.32767.32767" newVersion="9.0.0.2" />
      </dependentAssembly>
      <dependentAssembly xmlns="urn:schemas-microsoft-com:asm.v1">
        <assemblyIdentity name="System.Text.Encoding.CodePages" publicKeyToken="b03f5f7f11d50a3a" />
        <bindingRedirect oldVersion="0.0.0.0-32767.32767.32767.32767" newVersion="8.0.0.0" />
      </dependentAssembly>

[lanthonyneville]

#7160 might have fixed this issue, if you have a non-production copy of that site, can you try to update it to this unreleased version https://github.com/dnnsoftware/Dnn.Platform/actions/runs/23907705426/artifacts/6244760181 to test.

This is not an official release, so don't install that on production yet, it is just to see if it fixes your issue.

To summarise the results so far: after applying the pre-release upgrade above (and getting past the assembly redirect issues above) the DDR Menu does now render. However, I am still seeing the below page load exception on the login page and the Login module not rendering:

Index was outside the bounds of the array.	   
at DotNetNuke.UI.WebControls.DNNTab.SaveViewState()
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Control.SaveViewStateRecursive(ViewStateMode inheritedMode)
at System.Web.UI.Page.SaveAllState()
at System.Web.UI.Page.<ProcessRequestMainAsync>d__523.MoveNext()

FYI, this is the standard Account Login module with one extra auth provider - DNN_ActiveDirectoryAuthentication 8.0.8

[valadas]

For the login part, assuming it is https://github.com/DNNCommunity/DNN.ActiveDirectory and maybe an issue could be opened there if you can identify that this is the culprit...

[lanthonyneville]

For the login part, assuming it is https://github.com/DNNCommunity/DNN.ActiveDirectory and maybe an issue could be opened there if you can identify that this is the culprit...

I'll look deeper into this. However I am almost 100% sure that nothing changed other than the upgrade from 10.2.X to 10.3.0. Under 10.2.X the login module with the AD provider was working. Did something maybe change in DotNetNuke.UI.WebControls.DNNTab.SaveViewState()?

[valadas]

If I am not mistaken, this is part of DotNetNuke.WebControls which was a dll directly in the codebase without any source code. That was bad and now we compile it from source right @bdukes ?

So maybe something unintentionally broke with that. It might be hard to exactly pinpoint so if we can confirm that this auth provider is part of the cause, it may help with troubleshooting and finding a fix specially if it is that open source one.