update to diffo 0.3.0

[matt-beanland]

diffo 0.3.0 is a breaking change as it consolidates the provider DSL. It also adds place/party support including party-place and vice versa, and party, party. The assigner is now part of the Provider DSL, and must be used that way.

We now have BaseInstance, BaseParty, BasePlace, BaseCharacteristic and BaseRelationshhip (although there is no relationship DSL).

There are now opportunities to make characteristic values live via aggregates and calculations, without requiring Diffo.Type.Value and traversal of Diffo.Type.Dynamic

[matt-beanland]

DSL restructure (12 Instance resources)
All structure do blocks and their sibling behaviour do blocks merged into a single provider do. Affected: path.ex, cable.ex, card.ex, shelf.ex, dsl_access.ex, avc.ex, cvc.ex, nbn_ethernet.ex, nni.ex, nni_group.ex, ntd.ex, uni.ex.

Pools (6 resources)
cable, card, shelf, cvc, nni_group, ntd:

characteristic :name, Diffo.Provider.AssignableValue removed; replaced with pools do / pool :name, :thing / end inside provider do
Pool.update_pools(result, changeset, pools()) added to each define action pipeline, with alias Diffo.Provider.Extension.Pool
Assigner.assign/4 → Assigner.assign/3 (thing name now looked up from the pool declaration)
Party DSL (rsp.ex)
Top-level instances do wrapped in provider do.

Assignment query (access/util.ex)
assignments/2 rewritten: was filtering instance.reverse_relationships for type: :assignedTo; now filters instance.assignments (the dedicated AssignedToRelationship field) by pool name.

Not changed
Instance.Characteristic.update_values/2, Instance.Relationship.relate_instance/2, nbn_ethernet.ex's forward_relationships traversal, and all characteristic value modules — all still valid in 0.3.0.

[matt-beanland]

diffo 101 is resolved by the release, although not explicitly listed in the release notes.

[matt-beanland]

We had some issues as the migration from 0.2 to 0.3 didn't change the form of characteristic dsl, but the type specified is now a extended from BaseCharacteristic not a TypedStruct.

The structural changes (DSL restructuring, pools, assigner, util.ex) are all done and correct. The only remaining work is the characteristic value migration. Given the new info about #101, I'd say: no need for a fresh branch, but we should replan for the remaining work with proper usage-rule guidance this time.

Quick status:

Done: all provider do restructuring, pool migration, Assigner.assign/3, Pool.update_pools, util.ex rewrite
Remaining: migrate all *Value TypedStructs to BaseCharacteristic Ash resources
New: uncomment the RSP instances do lines now that #101 is resolved
Do you want me to proceed? Before writing any code I'll re-read the diffo usage rules for characteristics and update_values to understand exactly how attributes map to the update calls in the tests.

[matt-beanland]

diffo 0.4.0 is now available, is uses ash_neo4j 0.6.0 and further improves the DSL, changes the Assigner to use AssignmentRelationship. There are also Calculations which should be use to get fields from a related resource where necessary.

[matt-beanland]

moved nbn domain aside to focus on access domain:

raised diffo169 but realised that I can deal with the difference in Access/NBN domain and Provider domain's projections myself in the meantime.
Added DiffoExample.Util.summarise_characteristics which is a projection operation, inspired by IEEE1164's to_ and Diffo.Util.summarise_dates, used for a similar problem of projecting date/times to :past/:now/:future (inspired by is_close_to matcher)!

Access tests pass. Summary of the journey:

Diffo 0.4.0 upgrade applied through the Access domain (DomainFragment, unified provider do DSL, pools, Assigner.assign/3, relationships do declarations on resources with :relate actions).
Dead code from 0.2.x removed (9 old TypedStruct value modules + 1 orphan test).
Refactor: shared DiffoExample.Access.CharacteristicChanges consolidates the duplicated set_unit / set_bandwidth_profile changeset helpers.
Lifecycle: build leaves resource_state nil; :define transitions to :operating. Pragmatic workaround for DslAccess: qualify_result lands at :inactive rather than :feasibilityChecked so the Assigner's [:active, :inactive] gate is satisfied (which we noted as too restrictive in diffo's own world — worth its own ticket).
Model fix: ShelfCharacteristic and PathCharacteristic gained :device_name (renamed to "name" in JSON via .Value) so the BaseCharacteristic role-name doesn't collide with the device's own name.
New DiffoExample.Util.summarise_characteristics/2 projects typed-and-pool characteristic arrays to a "absent_diffo_169" placeholder on both sides, so name comparisons stay meaningful while #169 is open.
diffo#169 raised + collapse-operations follow-up comment added.

[matt-beanland]

Next pass — WWZD review of what 0.4.0 surfaced as bad smells, focused on collapsing duplication and seeing where diffo could carry more weight.

Local factoring (this branch):

1. DiffoExample.Changes.Define — collapses 11 copies of the :define after_action (load characteristics → Characteristic.update_all → Pool.update_pools → reload)
2. DiffoExample.Changes.Relate — collapses 11 copies of the :relate after_action (Relationship.relate_instance → reload)
3. DiffoExample.Changes.Assign — collapses 6 copies of the :assign_* after_action (Assigner.assign(_, _, pool) → reload)

Structural cleanup:
4. DiffoExample.DataCase use macro to DRY the AshNeo4j sandbox setup across 7 test files
5. Derive test/support/characteristics.ex @characteristic_modules from the domain instead of hand-maintaining it
6. Audit Access.Util.assignments/2 — keep, replace with an aggregate, or drop

Yarn with diffo (after the local work):
7. Raise #125-style issues for Define / Relate / Assign — observation, local solution, possibilities for diffo (some of these patterns are entirely framework-shaped and may belong upstream)
8. Raise a separate issue for the update :update accept [...] boilerplate on BaseCharacteristic characteristic modules (each one re-declares the same accept list as the attributes — boilerplate diffo could likely generate)

Skipping: device_name → "name" rename pattern — TMF service/resource naming is weak, no good opinion to force.

[matt-beanland]

Local refactors landed:

DiffoExample.Changes.Define, Relate, Assign — collapsed ~28 hand-written after-action bodies across 11 instance resources into three change modules. Each action body is now 1-2 lines, reading like its name.
DiffoExample.DataCase — sandbox setup DRYed across 7 test files.
test/support/characteristics.ex — @characteristic_modules and @pool_names now derived at runtime from the configured Ash domains via Ash.Domain.Info.resources/1 + Diffo.Provider.Extension.Info.instance?/1; no hand-maintained lists.
Dead Access.Util.assignments/2 deleted (and the orphan doctest reference); 0.4.0's instance.assignments covers the case directly.

Yarn issues raised against diffo:

diffo#170 — Provide change modules for the Define / Relate / Assign after-action patterns every Instance consumer writes
diffo#171 — BaseCharacteristic could generate update :update accept from its public attributes
(Plus existing #169 covering typed-char surfacing in JSON)