#51 part 1 — drop JSON:API surface

* removed direct :ash_json_api dep, the AshJsonApi.Domain extension,
  the json_api do ... routes block on Nbn, and json_api blocks /
  AshJsonApi.Resource extensions on all NBN resources
* deleted lib/nbn/api_router.ex
* router now serves /catalog + /mcp only; everything else 404s
* MCP becomes the only externally-callable surface
* 54/54 tests pass

Author: matt-beanland

config/config.exs

@@ -16,7 +16,6 @@ config :spark,
         :characteristics,
         :neo4j,
         :jason,
-        :json_api,
         :outstanding,
         :actions,
         :state_machine,

lib/nbn/api_router.ex

@@ -15,7 +15,7 @@ defmodule DiffoExample.Nbn do
   use Ash.Domain,
     otp_app: :diffo,
     fragments: [Diffo.Provider.DomainFragment],
-    extensions: [AshAi, AshJsonApi.Domain]
+    extensions: [AshAi]
 
   alias DiffoExample.Nbn.NbnEthernet
   alias DiffoExample.Nbn.Uni
@@ -86,77 +86,6 @@ defmodule DiffoExample.Nbn do
     tool :deactivate_rsp, Rsp, :deactivate
   end
 
-  json_api do
-    routes do
-      base_route "/nbnEthernet", NbnEthernet do
-        index :read
-        get :read
-        post :build
-        patch :define
-        patch :relate, route: "/:id/relate"
-        delete :destroy
-      end
-
-      base_route "/uni", Uni do
-        index :read
-        get :read
-        post :build
-        patch :define
-        patch :relate, route: "/:id/relate"
-        delete :destroy
-      end
-
-      base_route "/avc", Avc do
-        index :read
-        get :read
-        post :build
-        patch :define
-        patch :relate, route: "/:id/relate"
-        delete :destroy
-      end
-
-      base_route "/ntd", Ntd do
-        index :read
-        get :read
-        post :build
-        patch :define
-        patch :relate, route: "/:id/relate"
-        delete :destroy
-      end
-
-      base_route "/cvc", Cvc do
-        index :read
-        get :read
-        post :build
-        patch :define
-        patch :relate, route: "/:id/relate"
-        delete :destroy
-      end
-
-      base_route "/nniGroup", NniGroup do
-        index :read
-        get :read
-        post :build
-        patch :define
-        patch :relate, route: "/:id/relate"
-        delete :destroy
-      end
-
-      base_route "/nni", Nni do
-        index :read
-        get :read
-        post :build
-        patch :define
-        patch :relate, route: "/:id/relate"
-        delete :destroy
-      end
-
-      base_route "/rsp", Rsp do
-        get :read
-      end
-    end
-  end
-
   resources do
     resource NbnEthernet do
       define :get_nbn_ethernet_by_id, action: :read, get_by: :id

lib/nbn/nbn.ex

@@ -19,18 +19,13 @@ defmodule DiffoExample.Nbn.Avc do
   use Ash.Resource,
     fragments: [BaseInstance],
     domain: Nbn,
-    extensions: [AshJsonApi.Resource],
     authorizers: [Ash.Policy.Authorizer]
 
   resource do
     description "An Ash Resource representing an Access Virtual Circuit (AVC)"
     plural_name :Avcs
   end
 
-  json_api do
-    type "avc"
-  end
-
   provider do
     specification do
       id "b2c3d4e5-6f7a-4b8c-9d0e-1f2a3b4c5d6e"

lib/nbn/resources/avc.ex

@@ -20,18 +20,13 @@ defmodule DiffoExample.Nbn.Cvc do
   use Ash.Resource,
     fragments: [BaseInstance],
     domain: Nbn,
-    extensions: [AshJsonApi.Resource],
     authorizers: [Ash.Policy.Authorizer]
 
   resource do
     description "An Ash Resource representing a Connectivity Virtual Circuit (CVC)"
     plural_name :Cvcs
   end
 
-  json_api do
-    type "cvc"
-  end
-
   provider do
     specification do
       id "d4e5f6a7-8b9c-4d0e-bf1a-3b4c5d6e7f8a"

lib/nbn/resources/cvc.ex

@@ -18,18 +18,13 @@ defmodule DiffoExample.Nbn.NbnEthernet do
   use Ash.Resource,
     fragments: [BaseInstance],
     domain: Nbn,
-    extensions: [AshJsonApi.Resource],
     authorizers: [Ash.Policy.Authorizer]
 
   resource do
     description "An Ash Resource representing an NBN Ethernet access"
     plural_name :NbnEthernets
   end
 
-  json_api do
-    type "nbnEthernet"
-  end
-
   provider do
     specification do
       id "f2a4c6e8-1b3d-4f5a-8c7e-9d0b2e4f6a8c"

lib/nbn/resources/nbn_ethernet.ex

@@ -20,18 +20,13 @@ defmodule DiffoExample.Nbn.Nni do
   use Ash.Resource,
     fragments: [BaseInstance],
     domain: Nbn,
-    extensions: [AshJsonApi.Resource],
     authorizers: [Ash.Policy.Authorizer]
 
   resource do
     description "An Ash Resource representing a Network-to-Network Interface (NNI)"
     plural_name :Nnis
   end
 
-  json_api do
-    type "nni"
-  end
-
   provider do
     specification do
       id "f6a7b8c9-0d1e-4f2a-9b3c-5d6e7f8a9b0c"

lib/nbn/resources/nni.ex

@@ -21,18 +21,13 @@ defmodule DiffoExample.Nbn.NniGroup do
   use Ash.Resource,
     fragments: [BaseInstance],
     domain: Nbn,
-    extensions: [AshJsonApi.Resource],
     authorizers: [Ash.Policy.Authorizer]
 
   resource do
     description "An Ash Resource representing an NNI Group"
     plural_name :NniGroups
   end
 
-  json_api do
-    type "nniGroup"
-  end
-
   provider do
     specification do
       id "e5f6a7b8-9c0d-4e1f-8a2b-4c5d6e7f8a9b"

lib/nbn/resources/nni_group.ex

@@ -20,7 +20,6 @@ defmodule DiffoExample.Nbn.Ntd do
   use Ash.Resource,
     fragments: [BaseInstance],
     domain: Nbn,
-    extensions: [AshJsonApi.Resource],
     authorizers: [Ash.Policy.Authorizer]
 
   resource do
@@ -71,10 +70,6 @@ defmodule DiffoExample.Nbn.Ntd do
     end
   end
 
-  json_api do
-    type "ntd"
-  end
-
   def identifier() do
     DiffoExample.Nbn.Util.identifier("NTD")
   end

lib/nbn/resources/ntd.ex

@@ -20,7 +20,7 @@ defmodule DiffoExample.Nbn.Rsp do
   use Ash.Resource,
     domain: Nbn,
     authorizers: [Ash.Policy.Authorizer],
-    extensions: [AshStateMachine, AshJsonApi.Resource],
+    extensions: [AshStateMachine],
     fragments: [Diffo.Provider.BaseParty]
 
   policies do
@@ -58,10 +58,6 @@ defmodule DiffoExample.Nbn.Rsp do
   #   actions: :read (primary), :destroy, :create (accept [:id,:name,:type,:referred_type]),
   #            :update (name), :list (unsorted), :find_by_name
 
-  json_api do
-    type "rsp"
-  end
-
   provider do
     instances do
       role :owns_avc, DiffoExample.Nbn.Avc