Skip to content

removed duplicate tests #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-beanland merged 1 commit into from
May 6, 2026
Merged

removed duplicate tests #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions test/instance_extension/characteristic_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
defmodule Diffo.InstanceExtension.CharacteristicTest do
@moduledoc false
use ExUnit.Case
alias Diffo.Test.Servo
alias Diffo.Test.Parties

setup_all do
Expand All @@ -19,14 +18,6 @@ defmodule Diffo.InstanceExtension.CharacteristicTest do
end

describe "characteristic" do
test "create resource fails when characteristic value type invalid" do
{:error, error} = Servo.build_invalid_characteristic(%{})
%Ash.Error.Invalid{errors: errors} = error

assert hd(errors).message ==
"couldn't create characteristic with value of unknown type Elixir.InvalidValue"
end

test "create resource with array characteristic - success" do
{:ok, shelf} = Parties.build_shelf_with_installer()

Expand Down
13 changes: 3 additions & 10 deletions test/instance_extension/feature_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
defmodule Diffo.InstanceExtension.FeatureTest do
@moduledoc false
use ExUnit.Case
alias Diffo.Test.Servo
alias Diffo.Test.Parties

setup_all do
Expand All @@ -19,19 +18,13 @@ defmodule Diffo.InstanceExtension.FeatureTest do
end

describe "feature" do
test "create resource with fails when feature characteristic value type invalid" do
{:error, error} = Servo.build_invalid_feature_characteristic(%{})
%Ash.Error.Invalid{errors: errors} = error

assert hd(errors).message ==
"couldn't create feature characteristic with value of unknown type Elixir.InvalidValue"
end

test "create resource with array feature characteristic - success" do
{:ok, shelf} = Parties.build_shelf_with_installer()

spectral = Enum.find(shelf.features, fn f -> f.name == :spectralManagement end)
deployment_classes = Enum.find(spectral.characteristics, fn c -> c.name == :deploymentClasses end)

deployment_classes =
Enum.find(spectral.characteristics, fn c -> c.name == :deploymentClasses end)

assert deployment_classes.is_array == true
assert deployment_classes.values == []
Expand Down
6 changes: 0 additions & 6 deletions test/instance_extension/specification_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@ defmodule Diffo.InstanceExtension.SpecificationTest do
end

describe "specification" do
test "create resource fails when specification id not uuid v4" do
{:error, error} = Servo.build_invalid_specification(%{})
%Ash.Error.Invalid{errors: errors} = error
assert hd(errors).message == "must be a uuid v4 or nil"
end

test "description declared in specification DSL roundtrips to the persisted specification" do
spec_id = Shelf.specification()[:id]
description = Shelf.specification()[:description]
Expand Down
44 changes: 0 additions & 44 deletions test/support/resource/invalid/invalid_characteristic.ex
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions test/support/resource/invalid/invalid_feature_characteristic.ex
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions test/support/resource/invalid/invalid_specification.ex
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions test/support/servo.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ defmodule Diffo.Test.Servo do
alias Diffo.Test.Card
alias Diffo.Test.Broadband
alias Diffo.Test.BroadbandV2
alias Diffo.Test.InvalidSpecification
alias Diffo.Test.InvalidCharacteristic
alias Diffo.Test.InvalidFeatureCharacteristic

domain do
description "service and resource management"
Expand Down Expand Up @@ -50,20 +47,5 @@ defmodule Diffo.Test.Servo do
define :build_broadband_v2, action: :build
define :get_broadband_v2_by_id, action: :read, get_by: :id
end

resource InvalidSpecification do
define :get_invalid_specification_by_id, action: :read, get_by: :id
define :build_invalid_specification, action: :build
end

resource InvalidCharacteristic do
define :get_invalid_characteristic_by_id, action: :read, get_by: :id
define :build_invalid_characteristic, action: :build
end

resource InvalidFeatureCharacteristic do
define :get_invalid_feature_characteristic_by_id, action: :read, get_by: :id
define :build_invalid_feature_characteristic, action: :build
end
end
end
Loading