agents and deps with failing tests

Author: matt-beanland

AGENTS.md

@@ -19,6 +19,13 @@ on [Ash Framework](https://www.ash-hq.org/) + [AshNeo4j](https://github.com/diff
 2. Read `CLAUDE.md` — dependency usage rules (Ash, Elixir, OTP, AshNeo4j, Spark).
 3. Consult the skill at `.claude/skills/diffo-framework/` for Ash ecosystem patterns.
 
+## Updating dependencies
+
+When updating a dependency (e.g. bumping `ash_neo4j`, `ash`, `spark` in `mix.exs`), always
+run `mix usage_rules.sync` immediately after `mix deps.get`. Dependencies publish their own
+usage rules; syncing pulls those changes into `CLAUDE.md` so you are working from the
+up-to-date guidance before touching any code.
+
 ## Project structure
 
 ```

lib/diffo/provider/components/instance/extension/characteristic.ex

@@ -7,8 +7,9 @@ defmodule Diffo.Provider.Instance.Characteristic do
   require Logger
 
   alias Diffo.Provider
-  alias Diffo.Provider.Instance
   alias Diffo.Type.Value
+  alias AshNeo4j.Resource.Info, as: Neo4jInfo
+  alias AshNeo4j.Neo4jHelper
 
   @doc """
   Struct for a Characteristic
@@ -66,10 +67,35 @@ defmodule Diffo.Provider.Instance.Characteristic do
   def relate_instance(result, changeset)
       when is_struct(result) and is_struct(changeset, Ash.Changeset) do
     characteristics = Ash.Changeset.get_argument(changeset, :characteristics)
+    relate_to_instance(result, characteristics)
+  end
 
-    Provider.relate_instance_characteristics(%Instance{id: result.id}, %{
-      characteristics: characteristics
-    })
+  # Directly create HAS edges in Neo4j rather than going through manage_relationship.
+  # manage_relationship on a has_many triggers accessing_from updates on each
+  # Characteristic, which break because Ash.Resource.Info.reverse_relationship
+  # finds no path back to the concrete resource (ShelfInstance etc.) — Characteristic's
+  # belongs_to :instance targets the generic Diffo.Provider.Instance, not the
+  # domain-specific subtype.
+  defp relate_to_instance(result, nil), do: {:ok, result}
+  defp relate_to_instance(result, []), do: {:ok, result}
+
+  defp relate_to_instance(result, char_ids) do
+    instance_label_pair = Neo4jInfo.label_pair(result.__struct__)
+    char_label = Neo4jInfo.label(Diffo.Provider.Characteristic)
+
+    Enum.reduce_while(char_ids, {:ok, result}, fn char_id, acc ->
+      case Neo4jHelper.relate_nodes(
+             instance_label_pair,
+             %{uuid: result.id},
+             char_label,
+             %{uuid: char_id},
+             :HAS,
+             :outgoing
+           ) do
+        {:ok, _} -> {:cont, acc}
+        {:error, error} -> {:halt, {:error, error}}
+      end
+    end)
   end
 
   @doc """

lib/diffo/provider/components/instance/extension/feature.ex

@@ -7,8 +7,9 @@ defmodule Diffo.Provider.Instance.Feature do
   require Logger
 
   alias Diffo.Provider
-  alias Diffo.Provider.Instance
   alias Diffo.Type.Value
+  alias AshNeo4j.Resource.Info, as: Neo4jInfo
+  alias AshNeo4j.Neo4jHelper
 
   @doc """
   Struct for a Feature
@@ -94,7 +95,33 @@ defmodule Diffo.Provider.Instance.Feature do
   def relate_instance(result, changeset)
       when is_struct(result) and is_struct(changeset, Ash.Changeset) do
     features = Ash.Changeset.get_argument(changeset, :features)
-    Provider.relate_instance_features(%Instance{id: result.id}, %{features: features})
+    relate_to_instance(result, features)
+  end
+
+  # Directly create HAS edges rather than going through manage_relationship,
+  # for the same reason as Characteristic: the accessing_from path breaks because
+  # Feature's belongs_to :instance targets Diffo.Provider.Instance, not the
+  # domain-specific concrete resource (ShelfInstance etc.).
+  defp relate_to_instance(result, nil), do: {:ok, result}
+  defp relate_to_instance(result, []), do: {:ok, result}
+
+  defp relate_to_instance(result, feature_ids) do
+    instance_label_pair = Neo4jInfo.label_pair(result.__struct__)
+    feature_label = Neo4jInfo.label(Diffo.Provider.Feature)
+
+    Enum.reduce_while(feature_ids, {:ok, result}, fn feature_id, acc ->
+      case Neo4jHelper.relate_nodes(
+             instance_label_pair,
+             %{uuid: result.id},
+             feature_label,
+             %{uuid: feature_id},
+             :HAS,
+             :outgoing
+           ) do
+        {:ok, _} -> {:cont, acc}
+        {:error, error} -> {:halt, {:error, error}}
+      end
+    end)
   end
 
   defimpl String.Chars do

lib/diffo/provider/components/instance/extension/specification.ex

@@ -7,7 +7,6 @@ defmodule Diffo.Provider.Instance.Specification do
   require Logger
 
   alias Diffo.Provider
-  alias Diffo.Provider.Instance
 
   @doc """
   Struct for a Specification
@@ -48,7 +47,13 @@ defmodule Diffo.Provider.Instance.Specification do
   def relate_instance(result, changeset)
       when is_struct(result) and is_struct(changeset, Ash.Changeset) do
     specified_by = Ash.Changeset.get_argument(changeset, :specified_by)
-    Provider.respecify_instance(%Instance{id: result.id}, %{specified_by: specified_by})
+
+    # Clear specification_id so manage_relationship sees nil→id (add only, no spurious remove).
+    # action_helper pre-sets specification_id before calling us, which would make
+    # Ash treat old==new and generate an empty-argument remove that fails.
+    %{result | specification_id: nil}
+    |> Ash.Changeset.for_update(:specify, %{specified_by: specified_by})
+    |> Ash.update()
   end
 
   defimpl String.Chars do

lib/diffo/provider/components/party_ref.ex

@@ -51,17 +51,11 @@ defmodule Diffo.Provider.PartyRef do
 
     create :create do
       description "creates a party ref, relating an instance, place or source party to a party"
-      accept [:role]
-
-      argument :instance_id, :uuid
-      argument :place_id, :string
-      argument :source_party_id, :string
-      argument :party_id, :string
-
-      change manage_relationship(:instance_id, :instance, type: :append_and_remove)
-      change manage_relationship(:place_id, :place, type: :append_and_remove)
-      change manage_relationship(:source_party_id, :source_party, type: :append_and_remove)
-      change manage_relationship(:party_id, :party, type: :append_and_remove)
+      # IDs accepted directly as attributes so AshNeo4j's create_from_attributes path
+      # builds graph edges using the single labels in the relate DSL (:Instance, :Party, :Place).
+      # manage_relationship would fail: it looks up the generic Diffo.Provider.Instance/Party
+      # by label_pair, which doesn't match domain-specific subtypes (ShelfInstance, Person, etc.).
+      accept [:role, :instance_id, :place_id, :source_party_id, :party_id]
     end
 
     read :list do

mix.exs

@@ -124,7 +124,7 @@ defmodule Diffo.MixProject do
       {:ash_outstanding, "~> 0.2.3"},
       {:ash_jason, "~> 3.0"},
       {:ash_state_machine, "~> 0.2.12"},
-      {:ash_neo4j, ash_neo4j_version("~> 0.5")},
+      {:ash_neo4j, ash_neo4j_version("~> 0.6")},
       {:bolty, ">= 0.0.12"},
       {:ash, ash_version("~> 3.0 and >= 3.24.2")},
       {:uuid, "~> 1.1"},